termux_change_repo: improve single mirror selector speed #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use bash builtins instead of external commands while scanning files.
2096779623
approved these changes
May 15, 2025
Member
2096779623
left a comment
There was a problem hiding this comment.
LGTM, it saves about 0.115s of time.
Member
Author
|
Lucky you, I had a second or two of difference :) . |
Member
Author
|
Merged as a part of #167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use bash builtins instead of external commands while scanning files.
Scanning list of single mirrors to be passed to
dialogtakes significant amount of time because of calling external utils, this change fixes it.