Added Auto-prepend https:// to URLs without scheme in termux-open-url #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have added script for the
https://scheme to URLs that do not already include a scheme.I have specifically added support for https:// as it is more secure compared to http://. Since security is a priority, I chose to default to https:// to ensure that URLs are opened over a secure connection whenever possible.http://support has not been added for this reason. We can add later too.Before the Change:
If a user tried to open a URL like
google.comwithout specifying the scheme, the script would fail, and the user would not be able to visit the link.After the Change:
Now, if a user provides a URL without a scheme (e.g., google.com), the script automatically adds
https://to the URL, redirecting user from a browser.