scripts: pkg: add update option #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since pkg install always runs apt update doesn't feel like a bit inconsistent? Like they'd have to use apt anyway for the update only command to be useful. |
Member
|
Thanks. @ravener Required to fix termux-tools/scripts/termux-change-repo.in Line 192 in a6aa2dd |
| un*|rem*|rm|del*) apt remove "$@";; | ||
| up*) select_mirror; apt update; apt full-upgrade "$@";; | ||
| upd*) select_mirror; apt update;; | ||
| upg*) select_mirror; apt update; apt full-upgrade "$@";; |
Member
There was a problem hiding this comment.
I think this should be following, otherwise will break existing scripts for package upgrade and comments in issues/reddit.
upd*) select_mirror; apt update;;
up*) select_mirror; apt update; apt full-upgrade "$@";;
There was a problem hiding this comment.
Why did this suggestion got ignored? I already see lots of complains about pkg up not working anymore.
Before pkg up* always did apt update && apt upgrade, with this it is possible to do only apt update, with pkg upd* (while pkg upg* does apt update && apt upgrade).
93e56b5 to
42226cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before pkg up* always did apt update && apt upgrade, with this it is possible to do only apt update, with pkg upd* (while pkg upg* does apt update && apt upgrade).