Use 'Fira' font files from Nerd Fonts upstream instead of 'Fura' #77
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rerun ./setup-nerd-fonts.sh
Member
|
Thanks! This will be part of the next |
|
I think the fira code font is out of date again, as some ligatures in the more recent versions dont appear to work. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The font files for Fira and Fira Code on Nerd Fonts were renamed from
Fura*toFira*9 months ago when the author of those fonts gave them permission to use the original name. This seems to have gone unnoticed here as because the oldFura*files remain (unupdated) in the Nerd Fonts repo (by mistake, I presume), the download script didn't break. These old versions of Fira Code have serious problems with some ligatures, which have already been fixed upstream.This PR modifies
setup-nerd-fonts.shto use theFira*versions. I also reran that script so the files in app/src/main/fonts are now up to date.