Allow everything to work before restarting the shell #34
Conversation
- Document `DAEMON_STOP_SIGNAL`
- Start in `${XDG_RUNTIME_DIR}`
- Use `case` to print the proper message
- Remove an unused local variable
Adjustments from review
service-daemon
Outdated
| echo "." | ||
| (restart) printf -- 'Restart' ;; | ||
| (start) printf -- 'Start' ;; | ||
| (stop) printf -- 'Stopp' ;; |
There was a problem hiding this comment.
This is still harming the readability of this code.
I do not see a benefit is keeping this printout DRY to such an extent.
I'm also kind of surprised to see that the enclosed parentheses form for case labels is part of the POSIX sh spec.
But I did check it in the documentation.
There was a problem hiding this comment.
I think the new function is good balance between duplicating in every case and the extent the previous version went to.
Let me know if you have a better way to maintain readability without duplicated messages for every case.
The open parentheses always look odd to me, so when I learned about the closed form, I was happy to start using that way instead.
| "${cmd}" | ||
| done | ||
| printf -- '.\n' | ||
| } |
There was a problem hiding this comment.
I still think this is overkill but it's not worth arguing over.
No description provided.