Fix typo in sv-enable/disable #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This tripped me up when I skimmed the wiki article and didn't see that I needed to restart my shell. That's my fault, but the original code is dead, seemingly serving no purpose since the test shouldn't evaluate to true in the case for which it's intended. If someone does approve this PR, it might also be worthwhile to add a hint in the error message about the appropriate next step after first-time installation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"-u" tests for SUID bit, not really useful here. "-z" (empty) is way more useful.
If "-u" is really useful, "-z" should also be added.