-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add termux-am-2 #8182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add termux-am-2 #8182
Conversation
thunder-coding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/tareksander/termux-am-2/blob/20f10c7396a9a3951067b3786c5e11637ce53b80/CMakeLists.txt#L12: It would make sense to use TERMUX_BASE_DIR instead of prefix. This will remove the need of "../" from https://github.com/tareksander/termux-am-2/blob/20f10c7396a9a3951067b3786c5e11637ce53b80/termux-am.c#L15
packages/termux-am-2/build.sh
Outdated
| @@ -0,0 +1,11 @@ | |||
| TERMUX_PKG_HOMEPAGE=https://github.com/tareksander/termux-am-2 | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the empty lines
packages/termux-am-2/build.sh
Outdated
| @@ -0,0 +1,11 @@ | |||
| TERMUX_PKG_HOMEPAGE=https://github.com/tareksander/termux-am-2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe termux-am-socket, or similar, could be a more descriptive name for the repo and package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel, the repo can be transferred to @termux. It will make maintaince of the utility easier for us.
|
Please put the socket in $PREFIX/var/run instead of /data/data/com.termux/files, that's what we tend to make other packages use for sockets |
|
What do you think about moving the repo to the github.com/termux namespace and continue development there? We would then send an organisation invite so that you get write access to everything. We can then also move your termux-gui plugin to github.com/termux, making it an "official" plugin (unless you prefer to keep it separate) |
|
When transferring ownership, do I have to use "Termux", "termux" or "@termux" as the organization name? |
If it would be in github.com/termux then it would under the termux organization on github, thereby grouping it with the other apps and termux-related repositories. All copyright would still belong to you, and maintainer/author fields can still point to you. Are you fine with us moving termux-am-2 to github.com/termux/? |
|
I'll transfer termux-am-2 now, then you can also give the repo a more appropriate name, I couldn't come up with a better one. |
It says "cannot find new owner github.com/termux". |
Use |
Now it says "You don’t have the permission to create public repositories on termux" |
Issue with that is that if |
I cloned and pushed it here: https://github.com/termux/termux-am-socket Also sent you an invite so that we can give you access to the repo, should be in your mail |
Hm, good point. Maybe /data/data/com.termux/files, or /data/data/com.termux/files/sockets or similar is better then |
|
Yeah, |
|
Maybe some other generic name could be used instead of |
While you're at it you can also do that for the am library repo I made that is used as a module in my termux-app PR: https://github.com/tareksander/termux-am-library |
|
You should be able to create the repo yourself once you accept the invitation. The |
It still gives me the same error and when trying to select termux when creating a new repo it says "insufficient permission". |
|
You have been added as a member, not owner, hence the issue. Grimler, can you handle the repo, I am away from laptop atm. |
Fixed, please try again! |
Thanks, it works now. |
Client to use the new am implementation from this PR: termux/termux-app#2458
And remove empty lines from build.sh.
This moves the socket location to /data/data/com.termux/files/api/am-socket.
Client to use the new am implementation from this PR: termux/termux-app#2458