这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@tareksander
Copy link
Member

Client to use the new am implementation from this PR: termux/termux-app#2458

Copy link
Member

@thunder-coding thunder-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,11 @@
TERMUX_PKG_HOMEPAGE=https://github.com/tareksander/termux-am-2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the empty lines

@@ -0,0 +1,11 @@
TERMUX_PKG_HOMEPAGE=https://github.com/tareksander/termux-am-2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe termux-am-socket, or similar, could be a more descriptive name for the repo and package?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel, the repo can be transferred to @termux. It will make maintaince of the utility easier for us.

@Grimler91
Copy link
Member

Please put the socket in $PREFIX/var/run instead of /data/data/com.termux/files, that's what we tend to make other packages use for sockets

@Grimler91
Copy link
Member

What do you think about moving the repo to the github.com/termux namespace and continue development there? We would then send an organisation invite so that you get write access to everything.

We can then also move your termux-gui plugin to github.com/termux, making it an "official" plugin (unless you prefer to keep it separate)

@tareksander
Copy link
Member Author

When transferring ownership, do I have to use "Termux", "termux" or "@termux" as the organization name?

@Grimler91
Copy link
Member

When transferring ownership, do I have to use "Termux", "termux" or "@termux" as the organization name?

If it would be in github.com/termux then it would under the termux organization on github, thereby grouping it with the other apps and termux-related repositories. All copyright would still belong to you, and maintainer/author fields can still point to you.
In any case, I understand if you want to keep termux-gui separate (just let us know if you at some point want to move it to this organization)

Are you fine with us moving termux-am-2 to github.com/termux/?

@tareksander
Copy link
Member Author

I'll transfer termux-am-2 now, then you can also give the repo a more appropriate name, I couldn't come up with a better one.

@tareksander
Copy link
Member Author

Are you fine with us moving termux-am-2 to github.com/termux/?

It says "cannot find new owner github.com/termux".

@agnostic-apollo
Copy link
Member

It says "cannot find new owner github.com/termux".

Use termux.

@tareksander
Copy link
Member Author

Use termux.

Now it says "You don’t have the permission to create public repositories on termux"

@agnostic-apollo
Copy link
Member

Please put the socket in $PREFIX/var/run instead of /data/data/com.termux/files,

Issue with that is that if $PREFIX doesn't exist and TermuxApplication just creates the var/run directory, then it would be incorrectly assumed that $PREFIX exists and bootstrap installation wouldn't be done. That may even result in some backward compatibility issues. API commands wouldn't run since their scripts like termux-reset and am wrapper wouldn't exist either. Maybe socket and var/run shouldn't be created if $PREFIX doesn't exist, that may work. Need to think more on this.

@Grimler91
Copy link
Member

Use termux.

Now it says "You don’t have the permission to create public repositories on termux"

I cloned and pushed it here: https://github.com/termux/termux-am-socket

Also sent you an invite so that we can give you access to the repo, should be in your mail

@Grimler91
Copy link
Member

Please put the socket in $PREFIX/var/run instead of /data/data/com.termux/files,

Issue with that is that if $PREFIX doesn't exist and TermuxApplication just creates the var/run directory, then it would be incorrectly assumed that $PREFIX exists and bootstrap installation wouldn't be done.

Hm, good point. Maybe /data/data/com.termux/files, or /data/data/com.termux/files/sockets or similar is better then

@agnostic-apollo
Copy link
Member

Yeah, /data/data/com.termux/files/sockets would be better.

@agnostic-apollo
Copy link
Member

Maybe some other generic name could be used instead of sockets if the directory is to be used for other stuff in future, like api or something even more generic.

@tareksander
Copy link
Member Author

I cloned and pushed it here:

While you're at it you can also do that for the am library repo I made that is used as a module in my termux-app PR: https://github.com/tareksander/termux-am-library

@agnostic-apollo
Copy link
Member

You should be able to create the repo yourself once you accept the invitation. The termux-app pull request would need to be reviewed before it can be merged. It likely has conflicts with my local commits. I'll try to look into it soon, busy with lot of stuff.

@tareksander
Copy link
Member Author

You should be able to create the repo yourself once you accept the invitation.

It still gives me the same error and when trying to select termux when creating a new repo it says "insufficient permission".

@agnostic-apollo
Copy link
Member

You have been added as a member, not owner, hence the issue. Grimler, can you handle the repo, I am away from laptop atm.

@Grimler91
Copy link
Member

You should be able to create the repo yourself once you accept the invitation.

It still gives me the same error and when trying to select termux when creating a new repo it says "insufficient permission".

Fixed, please try again!

@tareksander
Copy link
Member Author

Fixed, please try again!

Thanks, it works now.

tareksander and others added 3 commits December 23, 2021 15:41
Client to use the new am implementation from this PR: termux/termux-app#2458
This moves the socket location to
/data/data/com.termux/files/api/am-socket.
@Grimler91 Grimler91 merged commit 1e9dcc0 into termux:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants