Add deprecation and future disabling of playstore builds warning to banner #7493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good! This: could be modified to make it clear who "they" are in the second part of the sentence. Perhaps: |
d800a48 to
d1a911b
Compare
Member
Author
|
@Grimler91 Done! If someone else doesn't suggest changes in next few hours, I'll bump |
ghost
approved these changes
Sep 9, 2021
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the duplicate. I forgot to re-commit before force pushing after undoing the single commit.
@Grimler91 and @buttaface thanks for the suggestions. I have tried to incorporate them from both of you. Its slightly shorter and will show even if banner is disabled.
I can't really say "The termux apps will be removed from Play store", since that requires involvement from @fornwall, who hasn't been responding on emails/sms.
I have updated https://github.com/termux/termux-app#installation as well and added deprecation details.
Let me know of any further changes.