fix(main/libgnustep-base): remove build tool manipulation #27286
Conversation
- Use system `robin-map` instead of package-specific one
|
Okay looks like I jinxed it... This is some sort of reverse cross-ISA issue where it works on non-native Archs but not on the Arch of the builder? |
…_PREFIX/bin` to `$PATH` - having `$TERMUX_PREFIX/bin` in `$PATH` severely breaks cross-compilations - on-device builds already have `$TERMUX_PREFIX/bin` in `$PATH` at all times, so editing it is not necessary for on-device builds - for similar reasons, also prevent `GNUstep.sh` from putting `$TERMUX_PREFIX/lib` in `$LD_LIBRARY_PATH`
- Fixes build with NDK r28c (after termux#25627) - No longer necessary after fixing `gnustep-make` to not put `$TERMUX_PREFIX/bin` in `$PATH` or `$TERMUX_PREFIX/lib` in `$LD_LIBRARY_PATH`
59b364e to
3cbcca6
Compare
Sorry for psyching you out with this, I just only fixed it for aarch64 first and then tested building for other architectures in CI. After figuring out what caused the problems for aarch64, x86_64 just needed a little bit more additional adjustment and it was not difficult for me to add that on, now it is fixed for all architectures. |
thanks, I have not checked For that reason, I have assumed that it probably has the same problem, and would probably also be fixed by NDK r29. |
|
I will merge it in 24 hours if no problems are found |
Progress on Some packages cannot be built 3: Revenge of the Xiph #23492
libobjc2: bump to 2.3gnustep-make: preventGNUstep.shfrom prepending$TERMUX_PREFIX/binto$PATH$TERMUX_PREFIX/binin$PATHseverely breaks cross-compilations$TERMUX_PREFIX/binin$PATHat all times, so editing it is not necessary for on-device buildsGNUstep.shfrom putting$TERMUX_PREFIX/libin$LD_LIBRARY_PATHlibgnustep-base: remove build tool manipulationgnustep-maketo not put$TERMUX_PREFIX/binin$PATHor$TERMUX_PREFIX/libin$LD_LIBRARY_PATH