-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
bump(main/libicu): 78.1 #27221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
bump(main/libicu): 78.1 #27221
Conversation
|
Arch dropped This patch was previously necessary for Thunderbird 115's calender tab to function correctly. Still no lead on the symbol issues, can't get it to add Linker errors:
make[1]: Making `all' in `makeconv'
make[2]: Entering directory '/home/builder/.termux-build/libicu/build/tools/makeconv'
(deps) /home/builder/.termux-build/libicu/src/source/tools/makeconv/ucnvstat.c
(deps) /home/builder/.termux-build/libicu/src/source/tools/makeconv/makeconv.cpp
(deps) /home/builder/.termux-build/libicu/src/source/tools/makeconv/genmbcs.cpp
(deps) /home/builder/.termux-build/libicu/src/source/tools/makeconv/gencnvex.c
aarch64-linux-android-clang ... /home/builder/.termux-build/libicu/src/source/tools/makeconv/gencnvex.c
cd ../.. \
&& CONFIG_FILES=tools/makeconv/makeconv.1 CONFIG_HEADERS= /bin/bash ./config.status
aarch64-linux-android-clang++ ... /home/builder/.termux-build/libicu/src/source/tools/makeconv/genmbcs.cpp
aarch64-linux-android-clang++ ... /home/builder/.termux-build/libicu/src/source/tools/makeconv/makeconv.cpp
aarch64-linux-android-clang ... /home/builder/.termux-build/libicu/src/source/tools/makeconv/ucnvstat.c
config.status: creating tools/makeconv/makeconv.1
aarch64-linux-android-clang++ -fstack-protector-strong -Oz -W -Wall -pedantic -Wpointer-arith -Wwrite-strings -Wno-long-long -std=c++17 -L/data/data/com.termux/files/usr/lib -Wl,-rpath=/data/data/com.termux/files/usr/lib -Wl,--enable-new-dtags -Wl,--as-needed -Wl,-z,relro,-z,now -o ../../bin/makeconv gencnvex.o genmbcs.o makeconv.o ucnvstat.o -L../../lib -licutu -L../../lib -licui18n -L../../lib -licuuc -L../../stubdata -licudata -lpthread -lm
ld.lld: error: undefined symbol: uprv_malloc_78
>>> referenced by gencnvex.c
>>> gencnvex.o:(CnvExtOpen)
>>> referenced by genmbcs.cpp
>>> genmbcs.o:(MBCSOpen)
>>> referenced by genmbcs.cpp
>>> genmbcs.o:(MBCSAddTable(NewConverter*, UCMTable*, UConverterStaticData*))
>>> referenced 1 more times
ld.lld: error: undefined symbol: uprv_free_78
>>> referenced by gencnvex.c
>>> gencnvex.o:(CnvExtClose)
>>> referenced by genmbcs.cpp
>>> genmbcs.o:(MBCSClose(NewConverter*))
>>> referenced by genmbcs.cpp
>>> genmbcs.o:(MBCSClose(NewConverter*))
>>> referenced 2 more times
ld.lld: error: undefined symbol: u_strFromUTF32_78
>>> referenced by gencnvex.c
>>> gencnvex.o:(generateToUTable)
>>> referenced by gencnvex.c
>>> gencnvex.o:(generateToUTable)
ld.lld: error: undefined symbol: u_getVersion_78
>>> referenced by makeconv.cpp
>>> makeconv.o:(main)
ld.lld: error: undefined symbol: u_getDataDirectory_78
>>> referenced by makeconv.cpp
>>> makeconv.o:(main)
ld.lld: error: undefined symbol: icu_78::StringPiece::StringPiece(char const*)
>>> referenced by makeconv.cpp
>>> makeconv.o:(main)
>>> referenced by makeconv.cpp
>>> makeconv.o:(main)
>>> referenced by makeconv.cpp
>>> makeconv.o:(main)
>>> referenced 3 more times
ld.lld: error: undefined symbol: icu_78::CharString::ensureEndsWithFileSeparator(UErrorCode&)
>>> referenced by makeconv.cpp
>>> makeconv.o:(main)
ld.lld: error: undefined symbol: icu_78::CharString::truncate(int)
>>> referenced by makeconv.cpp
>>> makeconv.o:(main)
>>> referenced by makeconv.cpp
>>> makeconv.o:(main)
ld.lld: error: undefined symbol: icu_78::CharString::lastIndexOf(char) const
>>> referenced by makeconv.cpp
>>> makeconv.o:(main)
ld.lld: error: undefined symbol: uprv_stricmp_78
>>> referenced by makeconv.cpp
>>> makeconv.o:(main)
ld.lld: error: undefined symbol: uprv_isInvariantString_78
>>> referenced by makeconv.cpp
>>> makeconv.o:(main)
ld.lld: error: undefined symbol: u_errorName_78
>>> referenced by makeconv.cpp
>>> makeconv.o:(main)
>>> referenced by makeconv.cpp
>>> makeconv.o:(main)
>>> referenced by makeconv.cpp
>>> makeconv.o:(main)
ld.lld: error: undefined symbol: icu_78::CharString::appendPathPart(icu_78::StringPiece, UErrorCode&)
>>> referenced by makeconv.cpp
>>> makeconv.o:(OUTLINED_FUNCTION_14)
ld.lld: error: undefined symbol: icu_78::CharString::append(char const*, int, UErrorCode&)
>>> referenced by makeconv.cpp
>>> makeconv.o:(icu_78::CharString::append(icu_78::StringPiece, UErrorCode&))
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Makefile:81: ../../bin/makeconv] Error 1
make[2]: Leaving directory '/home/builder/.termux-build/libicu/build/tools/makeconv'
make[1]: *** [Makefile:47: all-recursive] Error 2
make[1]: Leaving directory '/home/builder/.termux-build/libicu/build/tools'
make: *** [Makefile:153: all-recursive] Error 2 |
I have determined that the symbol errors are prefix pollution |
Should have thought of that, must have been from the ffmpeg rebuild tests. |
|
There is a problem with |
Yeah I got nothing... |
|
Looks like |
|
The CI is getting hit pretty hard by the rebuilds. |
That is also related to NDK r28c. I tried to fix that for a long time (several months), but I haven't been able to. The error is extremely complicated. I believe the error is likely to be reproducible on FreeBSD once FreeBSD attempts to bump their |
|
CI was running out of space. |
This error in the current Rust in some packages
but I'm not sure if there is any case where doing that could have a side effect or not. I don't really know what it means |
|
Got everything that will build building now. Let's look at the damage.
This PR cannot go ahead until we have |
I just applied help: try using a raw pointer method instead; or if this reference is intentional, make it explicit
|
55 | let old_len = (&(*old)).len();
| ++ + |
OpenBSD has it at 2.50.1, that might be helpful? Though I assume you've already looked at that. |
I did not know that, thanks. That makes it seem like the issue is completely specific to Android, but there could be an unknown difference between the build settings of each package. |
I might have started to figure out what is wrong with |
|
The build error in |
|
Thanks, will be testing that again. |
Currently fails with symbol errors.
Need to investigate.
Rebuild list:
Can be done in this PR:
cargo's suggestion worked to fix the issue)Probably need their own PRs: