bump(main/mdbook) :v0.5 #27160
Closed
bump(main/mdbook) :v0.5 #27160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
robertkirkman
requested changes
Nov 8, 2025
TomJo2000
reviewed
Nov 8, 2025
Member
TomJo2000
left a comment
There was a problem hiding this comment.
Why are we updating this package to a beta release anyway?
We don't ship beta for a lot of packages, so why for mdbook?
packages/mdbook/build.sh
Outdated
| TERMUX_PKG_MAINTAINER="@termux" | ||
| TERMUX_PKG_VERSION="0.4.52" | ||
| TERMUX_PKG_REVISION=1 | ||
| TERMUX_PKG_VERSION="0.5.0-beta.2" |
Member
There was a problem hiding this comment.
- As mentioned before is both bump(root/nexttrace): v1.5.0 #27157 (comment) and bump(root/nexttrace): v1.5.0 #27158 (comment)
This is gonna need a~instead of a-.
You'll also need to fix up the variable expansion in the SRCURL when doing that.
as previously stated in bump(root/nexttrace): v1.5.0 #27157 (comment)
Contributor
Author
There was a problem hiding this comment.
well i had initially added the ~ but forgot to update the variable expansion so that happed and for the y are we shipping beta updates cus idk random motivation ig
Member
There was a problem hiding this comment.
No other package of mdbook is shipping 0.5.0-beta.2.
Well besides crates.io, but that's the registry for rust packages.
https://repology.org/project/mdbook/versions
So I don't think there is a clear case for why we should be shipping it.
Contributor
|
Please double check your commit message |
Member
|
Superseded by #27283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.