tar: another hard link bites the dust #27150
Conversation
this hard link caused unzip to fail to install in debian proot proot -r ../debian /bin/bash apt install unzip this aborted my hundred packets large R install from r-base-core packet try to find a message about this up stream . the world is going mobile every one is away . need debian on the go. debian has a gazillion packet and many work you can use it on the train the debian must be freed from tyranny of the hard links. we have suffered too much for too long. we must rise up against the tyrant over mind and drape the world in soft links # the road ahead for proot debian . new minimal debian proot boot strap . minimal down load this might be included in termux on first use and recommend in /etc/motd . some people have never heard about debian repo in termux or avoid the large pre download image for proot-distro . only around fifty meg is necessary to boot strap debian with apt config file a new debian.conf file for apt can be included to boot strap new debian proot apt -c debian.conf install apt bash I avoided proot-distro in the longest because of the large pre download several hundred meg . try to work on my dpkgx boot strap approach where only fifty meg is required to start a distro. it should show up in a search I am offline now so I can't try it gh search commits dpkgx gh search ... --author john-peterson dpkgx all distro work with the same principle all placket manager can be tricked to install itself in a folder . that can then live on its own I can only ask every one to try debian on their phone so I don't have to patch every thing for it myself . It has one killer app R that i need on my phone more than anything . x86 compiler to test qemu and endless more useful packets already built for arm64 and running in termux with no or minimal patches needed
TomJo2000
left a comment
There was a problem hiding this comment.
This PR is missing a bump to the TERMUX_PKG_REVISION to indicate that this is a newer version of the tar package.
There was a problem hiding this comment.
The linkat() call you patched is in the extract_link() function.
Changing it to a symlinkat() breaks the explicit intended behavior of the extract_link() function.
A better approach may be to replace the extractor for case LNKTYPE: in prepare_to_extract()
diff --git a/src/extract.c b/src/extract.c
index 314d8bc0..1207f3ad 100644
--- a/src/extract.c
+++ b/src/extract.c
@@ -1694,7 +1694,7 @@ prepare_to_extract (char const *file_name, int typeflag, tar_extractor_t *fun)
break;
case LNKTYPE:
- extractor = extract_link;
+ extractor = extract_symlink;
break;
#if S_IFCHRThis way we aren't changing the behavior of any of the extractor functions, we merely change the extractor function being applied.
We're also sidestepping needing to deal with the linkat() calls in apply_delayed_link() since those have a fallthrough for symlinking if hardlinking isn't an option.
I am still unsure what the implications of changing the extractor type for hardlinks are, there may be unintended consequences to this patch.
|
Closing as unmergable and unsubstantiated. |
this hard link caused unzip to fail to install in debian proot
proot -r ../debian /bin/bash
apt install unzip
this aborted my hundred packets large R install from r-base-core packet
try to find a message about this up stream . the world is going mobile every one is away . need debian on the go. debian has a gazillion packet and many work you can use it on the train
the debian must be freed from tyranny of the hard links. we have suffered too much for too long. we must rise up against the tyrant over mind and drape the world in soft links
the road ahead for proot debian . new minimal debian proot boot strap . minimal down load
this might be included in termux on first use and recommend in /etc/motd . some people have never heard about debian repo in termux or avoid the large pre download image for proot-distro . only around fifty meg is necessary to boot strap debian with apt config file
a new debian.conf file for apt can be included to boot strap new debian proot
apt -c debian.conf install apt bash
I avoided proot-distro in the longest because of the large pre download several hundred meg . try to work on my dpkgx boot strap approach where only fifty meg is required to start a distro. it should show up in a search I am offline now so I can't try it
gh search commits dpkgx
gh search ... --author john-peterson dpkgx
all distro work with the same principle all placket manager can be tricked to install itself in a folder . that can then live on its own
I can only ask every one to try debian on their phone so I don't have to patch every thing for it myself . It has one killer app R that i need on my phone more than anything . x86 compiler to test qemu and endless more useful packets already built for arm64 and running in termux with no or minimal patches needed