fix(main/perl): create .placeholder to prevent termux_step_massage() from deleting empty sitearch folder from the package
#27137
+22
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…()` from deleting empty `sitearch` folder from the package - Fixes termux#27136 by preventing `termux_step_massage()` from deleting the empty folder `/data/data/com.termux/files/usr/lib/perl5/site_perl/5.40.3/aarch64-android/` from the `perl` package so that it is detected as present and writable by `cpan/CPAN/lib/CPAN/FirstTime.pm` during the command `cpan -i XML::Parser` during `postinst` scripts, which results in the command `cpan -i XML::Parser` working more consistently and reliably
robertkirkman
commented
Nov 6, 2025
| +++ b/cpan/CPAN/lib/CPAN/FirstTime.pm | ||
| @@ -904,7 +904,6 @@ sub init { | ||
| unless ( $matcher | ||
| || _can_write_to_libdirs() || _using_installbase() || _using_sudo() |
Member
Author
There was a problem hiding this comment.
This patch cpan-force-auto-local-lib.patch is no longer necessary to prevent the infinite loop after the development of create-placeholder-in-empty-sitearch-dir.patch, because create-placeholder-in-empty-sitearch-dir.patch causes the function seen here _can_write_to_libdirs() to return True instead of False, which diverts the cpan/CPAN/lib/CPAN/FirstTime.pm away from this non-functioning codepath and into a working codepath, resulting in
being fixed.
Member
Author
|
It does fix the issue I reported for me in actual testing, so I will merge it in 24 hours if no other problems are found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpan -iinpostinstscripts does not install Perl modules in an accessible location #27136 by preventingtermux_step_massage()from deleting the empty folder/data/data/com.termux/files/usr/lib/perl5/site_perl/5.40.3/aarch64-android/from theperlpackage so that it is detected as present and writable bycpan/CPAN/lib/CPAN/FirstTime.pmduring the commandcpan -i XML::Parserduringpostinstscripts, which results in the commandcpan -i XML::Parserworking more consistently and reliably