build-all.sh: improvements #27038
build-all.sh: improvements #27038
Conversation
| --library $(test "${PKG_DIR%/*}" = "gpkg" && echo "glibc" || echo "bionic") \ | ||
| ${TERMUX_OUTPUT_DIR+-o $TERMUX_OUTPUT_DIR} $TERMUX_INSTALL_DEPS "$PKG_DIR" \ | ||
| > "$BUILDALL_DIR"/"${PKG}".out 2> "$BUILDALL_DIR"/"${PKG}".err | ||
| &> "$BUILDALL_DIR"/"${PKG}".out |
There was a problem hiding this comment.
I also prefer stdout and stderr in a single log as well, however, I remember that Grimler didn't like this:
and this is subjective. For some other people who are not you and me, stdout and stderr in separate logs might be easier to handle and understand, and that might be the reason why they were written to save in separate logs to begin with.
@Grimler91 what do you think about it now that it is in a separate PR?
There was a problem hiding this comment.
I'm personally fine with this change, but it should probably be a separate commit.
There was a problem hiding this comment.
I'm personally fine with this change, but it should probably be a separate commit.
I think that splitting commits doesn't make sense because the PR is small.
b4cf2f0 to
a8e1991
Compare
|
Looks fine from a quick look. |
- added the ability to change the package format - added library base check by package name - the method of saving processes in the logo has been changed - use `case` to check the `TERMUX_FORMAT` and `TERMUX_ARCH` variables
a8e1991 to
552f633
Compare
|
If you have no complaints about the PR (especially @Grimler91), then I will try to merge it today. |
|
I think that Grimler does not get pings on GitHub, he also did not respond to my PR so I am just waiting, for my PR I was going to just wait for a long time but if you want to merge your PR soon you might need to message him somewhere else |
|
There is nothing complex here, so you can merge, assuming tom and robert has tested the changes. |
The changes were taken from PR #20513 - 3c0f7b9