make PS1 dynamic and shell-specific #2554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PS1 is not supposed to be an environment variable (i.e. will not be listed in `printenv` but only in `set`). Its value should also be shell-specific. With this commit we can stop exporting a static PS1 as env var on the java side. The prompt would now indicate whether the current user is root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS1 is not supposed to be an environment variable (i.e. will not
be listed in
printenvbut only inset). Its value should alsobe shell-specific.
With this commit we can stop exporting a static PS1 as env var on
the java side.
The prompt would now indicate whether the current user is root.