fix(x11/icewm): set $TERMUX_PREFIX throughout the software
#25466
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93b3922 to
a13e1bc
Compare
- `termux-exec` should handle the path replacement for most of these, but patch all of them just in case - I checked, and there is no string `/usr` or `/etc` in the code of IceWM that is not representing a UNIX-like system resources folder path or et cetera path respectively that can be safely and correctly replaced with `$TERMUX_PREFIX`, therefore this global replacement is safe - This is a rewrite of the patch that was lost in termux-user-repository/tur#1876, because unfortunately, I did not realize until too late that an older version of IceWM was already present in the TUR. I don't want to cause the loss of any fixes that correctly replacing `/usr` with `$TERMUX_PREFIX` globally in IceWM might have had.
a13e1bc to
60bc2e5
Compare
|
Since you created the original version of this patch for IceWM, if it's not too inconvenient for you, I would be very interested to know if you think this way of writing the patch is OK, or if you know of any problem this causes that your version doesn't have. Don't rush to test this if you are busy, there is no hurry for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
termux-execshould handle the path replacement for most of these, but patch all of them just in caseI checked, and there is no string
/usror/etcin the code of IceWM that is not representing a UNIX-like system resources folder path or et cetera path respectively that can be safely and correctly replaced with$TERMUX_PREFIX, therefore this global replacement is safe(PREFIX)/etc/shellsand(PREFIX)/etc/passwd. I tried for a little while to implement those features overtermux-tools[shells implementation] /termux-auth[passwd implementation], but I wasn't able to do that yet. As far as I can tell, if these features are not available, they just don't do anything and everything else in IceWM works normally)This is a rewrite of the patch that was lost in icewm: moved to main termux-user-repository/tur#1876, because unfortunately, I did not realize until too late that an older version of IceWM was already present in the TUR. I don't want to cause the loss of any fixes that correctly replacing
/usrwith$TERMUX_PREFIXglobally in IceWM might have had.