fix: do not imply platform independent for metapackages #25425
Conversation
| # Usually metapackages are also platform dependent but it is not always the | ||
| # right decision to mark them as such when they depend on packages which may | ||
| # not be available for all architectures | ||
| # TERMUX_PKG_PLATFORM_INDEPENDENT=true |
There was a problem hiding this comment.
I agree with this. Technically, any package which depends on a package that does not exist on some (OS-supported) architectures is not architecture independent - it is dependent on the existence of the dependency package, which does not exist on some architectures.
Since it is convenient to post it here for reference by anyone reading this PR in the future, the reason why this ends up mattering and is necessary is because the folder organization patterns of the mirrors can vary, and in at least some cases, packages marked as platform-independent are placed into the same folder for all architectures and cannot be "hidden" from the apt install commands of devices that have an architecture that is not supported by one of the dependencies of the package marked as architecture-independent, which is why it is necessary to use this specific definition of "architecture independent".
termux-packages/scripts/build/termux_download_deb_pac.sh
Lines 69 to 70 in a9ced23
is not platform independent
d01467f to
0934127
Compare
All the build.sh files in the repository for metapackages are also
setting TERMUX_PKG_PLATFORM_INDEPENDENT=true, so this does not need any
changes at all in any of the build.sh files
The only exception are dotnet-host and netstandard-targeting-pack-2.1
due to 2c2daf3 and
07d53e5
Closes #25417