-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
addpkg(x11/dconf-editor): 45.0.1 #25420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
should i do this https://github.com/termux/termux-packages/pull/25420/files#diff-b858e419af0ac121a2a853ed77459db2c95422339cbc7424aff456f703055563R21 or should i use TERMUX_PKG_RM_AFTER_INSTALL |
|
Probably, you should use Here is an example of that being done in another package; there might be a way to do something similar here. termux-packages/packages/boinc/client-scripts-Makefile.am.patch Lines 12 to 20 in 10398cd
|
|
This patch seems to do the trick, doesn't it? --- a/service/meson.build
+++ b/service/meson.build
@@ -10,15 +10,6 @@ configure_file(
install_dir: dbus_session_service_dir,
)
-systemd_service = 'dconf.service'
-
-configure_file(
- input: systemd_service + '.in',
- output: systemd_service,
- configuration: service_conf,
- install_dir: systemd_userunitdir,
-)
-
lib_sources = [
'dconf-blame.c',
'dconf-keyfile-writer.c',If you wanted to expand your idea (systemd does not work in termux, so any files in Alternatively, depending on what you prefer, If you would like to propose globally deleting all termux-packages/scripts/build/termux_step_massage.sh Lines 16 to 26 in a9ced23
I'm not sure if everyone would agree that this is a good idea, because systemd service files may be read by users who are familiar with systemd on GNU/Linux in order to understand how to manually launch the service without having systemd, but if the reason you want to remove the |
|
I do not have a strong opinion either way on whether all systemd-related files should be deleted from Termux; they don't do anything, but as far as I am aware they don't break anything by being there. |
But for dconf there was some error, so I tested it with gnome and because of that file gnome failed to launch, for some reason it was trying to start the systemd service file or something like that. i think patching the meson.build will be the best option but adding a patch file mean it might failed in future, so someone have to manually fix that old patch file all the time. where with TERMUX_PKG_RM_AFTER_INSTALL you will not have any issue like that. |
Wow, I did not actually know that having in this case, if you think termux-packages/scripts/build/termux_step_massage.sh Lines 16 to 26 in a9ced23
since GNOME is a draft PR currently, if the errors can only be reproduced while using GNOME, then maybe the global removal should be considered for that PR. |
|
for adding that rm -rf lib/systemd in termux_step_massage, i think that more related to Gnome Shell pr, so i think licy183 should add that in that pr to fix issue related to gnome |
|
@robertkirkman one thing out of this pr, do you know how can i set the file picker to nautilus, even though i install nautilus it still uses the gtk3 file picker, is there any package i need to install to make it work. |
|
I am not completely sure exactly what you mean, but if you can record a video of what you would like to have happen as it currently exists in desktop Linux like Ubuntu or Fedora, then I could try to copy and paste that to Termux. I think that "file picker" and "file browser" are slightly different programs, and I am not sure exactly if it is possible to "set nautilus as file picker" |
|
Oh hmm, I think that what you might be referring to is: setting " I am not completely sure whether doing that will work in Termux. |
|
thanks for the info |
This pr add the dconf-editor packages.
closes #25419