-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
re-enable alacritty copy/paste #25238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@licy183 i'm not sure if you meant to drop the whole cargo vendor route, or just the blanket vendored-sources; It seems to be working fine without it. |
@licy183 @TomJo2000 any other feedback on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patches look fine to me.
I do have some codestyle feedback for the build.sh
.
I'm not sure why you seem to be enforcing a 80 column line length, that's not a standard we follow and I think the line continuations mostly hurt the readability here.
Co-authored-by: TomIO <43716232+TomJo2000@users.noreply.github.com>
Co-authored-by: TomIO <43716232+TomJo2000@users.noreply.github.com>
Co-authored-by: TomIO <43716232+TomJo2000@users.noreply.github.com>
Co-authored-by: TomIO <43716232+TomJo2000@users.noreply.github.com>
If this is ready, could the commit history be squashed so that there are fewer small commits with short descriptions, and instead one to three large commits with all the changes made by each one listed? Each commit should contain |
copypasta
, so clipboard support now works properly on Termux.