这是indexloc提供的服务,不要输入任何密码
Skip to content

re-enable alacritty copy/paste #25238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

c0decafe
Copy link

@c0decafe c0decafe commented Jul 2, 2025

  • Previously, copy/paste was disabled on Android using a patch (which i suspect is linked to a @TERMUX_PREFIX@ interpolation bug i also addressed)
  • I adapted that logic and upstreamed it to copypasta, so clipboard support now works properly on Termux.

@c0decafe c0decafe requested a review from TomJo2000 as a code owner July 2, 2025 13:16
@c0decafe
Copy link
Author

c0decafe commented Jul 3, 2025

@licy183 i'm not sure if you meant to drop the whole cargo vendor route, or just the blanket vendored-sources; It seems to be working fine without it.

@c0decafe
Copy link
Author

c0decafe commented Jul 8, 2025

@licy183 @TomJo2000 any other feedback on this?

Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patches look fine to me.
I do have some codestyle feedback for the build.sh.

I'm not sure why you seem to be enforcing a 80 column line length, that's not a standard we follow and I think the line continuations mostly hurt the readability here.

c0decafe and others added 4 commits July 9, 2025 00:40
Co-authored-by: TomIO <43716232+TomJo2000@users.noreply.github.com>
Co-authored-by: TomIO <43716232+TomJo2000@users.noreply.github.com>
Co-authored-by: TomIO <43716232+TomJo2000@users.noreply.github.com>
Co-authored-by: TomIO <43716232+TomJo2000@users.noreply.github.com>
@robertkirkman
Copy link
Contributor

If this is ready, could the commit history be squashed so that there are fewer small commits with short descriptions, and instead one to three large commits with all the changes made by each one listed?

Each commit should contain fix(x11/alacritty): at the beginning of the description, and then have an explanation of what it changes inside alacritty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants