fix(main/openjdk): Build jsound and regerate patchset #25152
Conversation
There was a problem hiding this comment.
@alexytomi fantastic job!!! I couldn't really figure out how to do this, but you did.
This build actually works to solve the problem as-is.
So that others understand how to test this PR: these are the commands that don't work currently in Termux, but will work and actually play audible sounds, if this PR is merged:
pkg upgrade
pkg install x11-repo
pkg install termux-x11-nightly xfce openjdk-21-x
export DISPLAY=:0 TERMUX_X11_XSTARTUP=xfce4-session
LIBGL_ALWAYS_SOFTWARE=1 termux-x11 &
wget https://www.oracle.com/technetwork/java/javasounddemo-150249.zip
unzip javasounddemo-150249.zip
cd JavaSoundDemo/
java -jar JavaSoundDemo.jar|
I'll see if I can "properly" do a So having the proper headers and metadata on the patches would be good to maintain. |
packages/openjdk-21/0005-android-prevent-build-of-libjsound-and-libsa.patch
Show resolved
Hide resolved
112f762 to
50656d4
Compare
|
@robertkirkman This PR undoes the reallignment at b30f9a8
Err figured it out, was using outdated java, oops |
|
Say should there be a readme about how to properly update the set? |
Thank you for writing the explanation in the PR description, I think it's sufficient for it to be there since it's associated with this set of changes |
This was disabled before someone made the `alsa-utils`, `alsa-lib` and `alsa-plugins` packages and added a pulseaudio backend to ALSA This is no longer true, we now have ALSA
Since we have ALSA, we can now use jsound, as it uses ALSA as the backend for linux
This was disabled before someone made the `alsa-utils`, `alsa-lib` and `alsa-plugins` packages and added a pulseaudio backend to ALSA
Since we have ALSA, we can now use jsound, as it uses ALSA as the backend for linux
Also regenerates for 21.0.8-ga
Also regenerates for 17.0.16-ga
|
Okay I've finished updating the patches for the updated Java and it seems to be applying good |
|
I believe that this is correct and that no patches have been removed that shouldn't be. I will merge this in 24 hours if no problems are found. |
WIP because git is refusing to apply the patches withgit amand thus I cannot regenerate them to make this a proper PRHelp appreciated.What did I do
git am'ed every patch that worked with that, then manually applied the patches after, using the file names, comments and commit history for the commit message, date and authorandroid: prevent build of libjsound and libsaintoandroid: Prevent build of libsaproc, please check if I attributed authors correctlyconfigure: do not require alsa, this was stoppinglibjsound.sofrom linking tolibasound.soso it needed to either beLD_PRELOAD'ed orpatchelf'edWhat should be done when updating this
git am path/to/patches/*.patchthe corresponding openjdk package foldergit format-patch <tag to the jdk version>(i.egit format-patch jdk-17.0.16-ga) to generate the patches (personally used-o dirto make copying easier)