`update-alternatives` fixes and improvements. #25113

TomJo2000 · 2025-06-19T23:59:05Z

This PR handles a few outstanding issues related to the alternatives system provided by dpkg's update-alternatives.

1.) Make nano the default $PREFIX/bin/editor.
Currently the editor with the highest priority is vim, which isn't shipped as part of the bootstrap but will override the editor executable when installed.
To avoid user confusion due to this, default to nano instead which is the editor we ship as part of the bootstrap.
2.) Making ncat-openbsd and nmap-ncat no longer conflict.
This PR adds an nc alternative group utilized by ncat-openbsd and nmap and resolves the file overlaps between the two packages.
It also removes the now unnecessary nmap-ncat subpackage in favor of making ncat-nmap part of the nmap package.
3.) Replacing default editor compilation options with $PREFIX/bin/editor.
I have set the compile time default editors for the cronie, w3m and (new with this PR) less packages to editor to better align with user preferences.
In conjunction with the promotion of nano to default editor this change does not change the defaults for cronie or w3m.
It does change the implicit default editor for less to nano instead of the project default vi.
- (re)closes less v command defaults to vi which may not be installed. #25074

packages/busybox/build.sh

packages/less/build.sh

TomJo2000 · 2025-06-20T16:53:35Z

I've now added a pager group.
It currently only includes less (50, default), more (25) and cat (1, last resort).

I'll be adding additional pager utilities in separate commits.

Additionally busybox can also provide nc, though I have only assigned it a priority of 10 for this purpose (same for its ability to provide vi and editor).

TomJo2000 · 2025-06-20T17:36:42Z

If there's any pager candidates I missed or any other groups that would make sense to add please leave a comment here.

packages/moar/build.sh

packages/util-linux/build.sh

packages/coreutils/build.sh

packages/busybox/build.sh

robertkirkman · 2025-06-20T19:52:16Z

When I look, it appears that Debian's build of git sets both DEFAULT_PAGER=pager and DEFAULT_EDITOR=editor, but termux's git doesn't.

https://repo.or.cz/git/debian.git/blob/77c0fc1dd8601a9552369b9e9ee95d129fe26aa1:/debian/rules#l17

termux-packages/packages/git/build.sh

Lines 14 to 22 in 299ca87

    
           TERMUX_PKG_EXTRA_CONFIGURE_ARGS=" 
        
           ac_cv_fread_reads_directories=yes 
        
           ac_cv_header_libintl_h=no 
        
           ac_cv_iconv_omits_bom=no 
        
           ac_cv_snprintf_returns_bogus=no 
        
           --with-curl 
        
           --with-expat 
        
           --with-shell=$TERMUX_PREFIX/bin/sh 
        
           --with-tcltk=$TERMUX_PREFIX/bin/wish

I think that would be another program that pager and editor should be set for.

TomJo2000 · 2025-06-20T19:53:41Z

When I look, it appears that Debian's build of git sets both DEFAULT_PAGER=pager and DEFAULT_EDITOR=editor, but termux's git doesn't.

https://repo.or.cz/git/debian.git/blob/77c0fc1dd8601a9552369b9e9ee95d129fe26aa1:/debian/rules#l17

termux-packages/packages/git/build.sh

Lines 14 to 22 in 299ca87

TERMUX_PKG_EXTRA_CONFIGURE_ARGS="

ac_cv_fread_reads_directories=yes

ac_cv_header_libintl_h=no

ac_cv_iconv_omits_bom=no

ac_cv_snprintf_returns_bogus=no

--with-curl

--with-expat

--with-shell=$TERMUX_PREFIX/bin/sh

--with-tcltk=$TERMUX_PREFIX/bin/wish

I think that would be another program that pager and editor should be set for.

That can be arranged.

robertkirkman · 2025-06-21T00:48:42Z

While looking for other programs that might contain vi as the default editor, I found two more: bashbug and gawkbug.

However, while gawkbug is present in Termux, bashbug is removed before distribution. bashbug can only be obtained in Termux by rebuilding the package.

It seems like it makes sense, since bugs in bash in Termux should not be reported directly to upstream (if not reproducible on PC), they should first be reported here and then forwarded if necessary.

Maybe gawk's build.sh should be edited to make it remove gawkbug like how bash removes bashbug?

termux-packages/packages/bash/build.sh

Line 37 in 6d9084f

TERMUX_PKG_RM_AFTER_INSTALL="share/man/man1/bashbug.1 bin/bashbug"

TomJo2000 · 2025-06-21T00:49:59Z

While looking for other programs that might contain vi as the default editor, I found two more: bashbug and gawkbug.

However, while gawkbug is present in Termux, bashbug is removed before distribution. It bashbug can only be obtained in Termux by rebuilding the package.

It seems like it makes sense, since bugs in bash in Termux should not be reported directly to upstream (if not reproducible on PC), they should first be reported here and then forwarded if necessary.

Maybe gawk's build.sh should be edited to make it remove gawkbug like how bash removes bashbug?

termux-packages/packages/bash/build.sh

Line 37 in 6d9084f

TERMUX_PKG_RM_AFTER_INSTALL="share/man/man1/bashbug.1 bin/bashbug"

That makes sense to me, feel free to split that out into its own PR.

- For consistency with `bash`: termux#25113 (comment) https://github.com/termux/termux-packages/blob/6d9084fcd742271e7c3eab852f0a34a6ed167d7e/packages/bash/build.sh#L37 - This kind of command prompts to autosend bug reports to gnu.org. - This is not desirable because the gnu.org bug tracker should not be overwhelmed by bugs from an esoteric platform that might not be convenient for upstream developers. - It is more efficient for bugs in Termux packages to be reported here, then forwarded to upstream issue trackers if reproducible on a mainstream desktop platform familiar to desktop developers. - It is assumed that is why the choice was made for `bash`, and that the same removal should be applied to `gawkbug`. ``` Send bug report to bug-gawk@gnu.org? [y/n] ```

- For consistency with `bash`: termux#25113 (comment) https://github.com/termux/termux-packages/blob/6d9084fcd742271e7c3eab852f0a34a6ed167d7e/packages/bash/build.sh#L37 - This kind of command prompts to autosend bug reports to gnu.org. - This is not desirable because the gnu.org bug tracker should not be overwhelmed by bugs from an esoteric platform that might not be convenient for upstream developers. - It is more efficient for bugs in Termux packages to be reported here, then forwarded to upstream issue trackers if reproducible on a mainstream desktop platform familiar to desktop developers. - It is assumed that is why the choice was made for `bash`, and that the same removal should be applied to `gawkbug`. ``` Send bug report to bug-gawk@gnu.org? [y/n] ``` - Remove references to `igawk`, which no longer seems to exist - Specify removal of `gawk-${TERMUX_PKG_VERSION}` explicitly instead of `gawk-*`

- `cat` is a last resort `pager`

- Clean up shellcheck warnings, mostly by quoting everything - Align build scripts more closely - Don't drop images, icons and tutorials from `emacs` package

- These 3 are tied together since the `ex`, `view`, `vim` `vimdiff` and `vimtutor` groups require changes in `vim`/`vim-gtk`'s package layouts. - Also stop dropping so many files from the `vim` package, we already ship `man1/evim.1`, `rvim`, `rview`, `ex` and the icons in `vim-gtk`

TomJo2000 · 2025-06-30T01:40:20Z

I'd like to get this merged ahead of Vim 9.1.1500 so I don't have to rebase this branch again.
(For context, Vim is currently at 9.1.1497 and since every patch gets released as a tag we have 3 patches until that, which is probably less than a day.)

TomJo2000 · 2025-06-30T02:31:48Z

I missed a couple typos.
Working on it.

TomJo2000 requested a review from Grimler91 as a code owner June 19, 2025 23:59

TomJo2000 force-pushed the update-alternatives-fixes branch 2 times, most recently from bf18de2 to 38dfa64 Compare June 20, 2025 00:37

TomJo2000 commented Jun 20, 2025

View reviewed changes

packages/busybox/build.sh Outdated Show resolved Hide resolved

robertkirkman reviewed Jun 20, 2025

View reviewed changes

packages/less/build.sh Show resolved Hide resolved

TomJo2000 force-pushed the update-alternatives-fixes branch 3 times, most recently from c91be62 to cca660b Compare June 20, 2025 16:52

TomJo2000 force-pushed the update-alternatives-fixes branch from cca660b to 3b69edc Compare June 20, 2025 17:19

TomJo2000 mentioned this pull request Jun 20, 2025

package request: Lazyread #2245

Closed

TomJo2000 requested review from Biswa96, robertkirkman and twaik June 20, 2025 17:37

TomJo2000 mentioned this pull request Jun 20, 2025

less v command defaults to vi which may not be installed. #25074

Closed

robertkirkman reviewed Jun 20, 2025

View reviewed changes

packages/moar/build.sh Show resolved Hide resolved

robertkirkman reviewed Jun 20, 2025

View reviewed changes

packages/util-linux/build.sh Outdated Show resolved Hide resolved

TomJo2000 force-pushed the update-alternatives-fixes branch from 3b69edc to b9f95b4 Compare June 20, 2025 18:47

robertkirkman reviewed Jun 20, 2025

View reviewed changes

packages/coreutils/build.sh Outdated Show resolved Hide resolved

packages/busybox/build.sh Outdated Show resolved Hide resolved

TomJo2000 force-pushed the update-alternatives-fixes branch 2 times, most recently from f866562 to a43fe87 Compare June 20, 2025 20:52

robertkirkman mentioned this pull request Jun 21, 2025

chore(main/gawk): remove gawkbug #25128

Merged

TomJo2000 added 22 commits June 30, 2025 03:39

chore(main/coreutils): adopt .alternatives system

b39c804

- `cat` is a last resort `pager`

chore(main/emacs, x11/emacs-x): adopt .alternatives system

dcd59d1

- Clean up shellcheck warnings, mostly by quoting everything - Align build scripts more closely - Don't drop images, icons and tutorials from `emacs` package

chore(packages/joe): adopt .alternatives system

9036967

chore(packages/jupp): adopt .alternatives system

c28b633

chore(packages/kakoune): adopt .alternatives system

6fedabf

chore(main/kibi): adopt .alternatives system

1aca485

chore(main/liblua51): adopt .alternatives system

08f0e49

chore(main/liblua52): adopt .alternatives system

af0a3c2

chore(main/liblua53): adopt .alternatives system

d152830

chore(main/liblua54): adopt .alternatives system

4f0f6b4

chore(packages/micro): adopt .alternatives system

9a8d1e3

chore(packages/ne): adopt .alternatives system

e73b203

chore(main/mg): adopt .alternatives system

2f9d8a9

chore(main/moar): adopt .alternatives system

6e0b78f

chore(main/most): adopt .alternatives system

ab4d0ab

chore(main/util-linux): adopt .alternatives system

39a635d

chore(packages/vis): adopt .alternatives system

c495bf5

chore(main/w3m): adopt .alternatives system

7c2f53f

chore(x11-packages/xfce4-session): adopt .alternatives system

8e6f305

chore(packages/zile): adopt .alternatives system

3fb16c4

chore(main/busybox): adopt .aternatives system

5e0781c

TomJo2000 force-pushed the update-alternatives-fixes branch from 7a6c30d to 5e0781c Compare June 30, 2025 01:40

TomJo2000 merged commit b6ca26d into termux:master Jun 30, 2025
11 checks passed

TomJo2000 deleted the update-alternatives-fixes branch June 30, 2025 02:10

TomJo2000 mentioned this pull request Jun 30, 2025

Alternatives typos #25208

Merged

robertkirkman mentioned this pull request Jun 30, 2025

[Bug]: update-alternatives does not always run makewhatis if appropriate #25217

Closed

robertkirkman mentioned this pull request Jul 17, 2025

[Bug]: termux_step_update_alternatives() has /dev/stderr: Permission denied inside termux-docker inside GitHub Actions #25377

Closed

Uh oh!

update-alternatives fixes and improvements. #25113

update-alternatives fixes and improvements. #25113

Uh oh!

Conversation

TomJo2000 commented Jun 19, 2025

Uh oh!

Uh oh!

Uh oh!

TomJo2000 commented Jun 20, 2025

Uh oh!

TomJo2000 commented Jun 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robertkirkman commented Jun 20, 2025

Uh oh!

TomJo2000 commented Jun 20, 2025

Uh oh!

robertkirkman commented Jun 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomJo2000 commented Jun 21, 2025

Uh oh!

TomJo2000 commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

TomJo2000 commented Jun 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`update-alternatives` fixes and improvements. #25113

`update-alternatives` fixes and improvements. #25113

robertkirkman commented Jun 21, 2025 •

edited

Loading

TomJo2000 commented Jun 30, 2025 •

edited

Loading