bump(main/sbcl): 2.5.4 #24566
Merged
bump(main/sbcl): 2.5.4 #24566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes termux#24526 - The auto update failed to proceed because I put the host SBCL download in `termux_download` instead of `TERMUX_PKG_SRCURL` and I forgot I did that, - However, there are some changes near areas patched by patch files, so the patches have to be rebased anyway - `disable-failing-tests-that-were-only-enabled-on-x86.patch`: In sbcl/sbcl@b219fb3, upstream disabled the failing x86-only test by commenting it out, but in rebasing, I have preserved the hunk to disable it on Android should it ever be enabled again upstream, as a reminder for the future that this test was failing on Android-x86 and might need to remain disabled even if upstream enables it again in the future. - `pass-testsuite-on-device.patch`: Upstream decided to add a null return check to the implementation of `sb-unix:unix-tmpfile()` as a result of discussion that was, in fact, related to its test failing on Termux shortly prior to the addition of `sbcl` to termux-packages, and that is OK and should not have any major effect on the tests we run here, because of our `termux_tmpfile()` implementation preventing it from returning null in most situations.
|
Tomjo2000, do you think that after the way I have written this |
|
Yeah that should work. I've been working on #23678 but it's tricky and has a lot of edgecases. This should also work on |
|
Ok, I will merge this in 24 hours from now if there are no other comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Auto update failing for sbcl #24526
The auto update failed to proceed because I put the host SBCL download in
termux_downloadinstead ofTERMUX_PKG_SRCURLand I forgot I did that,However, there are some changes near areas patched by patch files, so the patches have to be rebased anyway
disable-failing-tests-that-were-only-enabled-on-x86.patch: In sbcl/sbcl@b219fb3, upstream disabled the failing x86-only test by commenting it out, but in rebasing, I have preserved the hunk to disable it on Android should it ever be enabled again upstream, as a reminder for the future that this test was failing on Android-x86 and might need to remain disabled even if upstream enables it again in the future.pass-testsuite-on-device.patch: Upstream decided to add a null return check to the implementation ofsb-unix:unix-tmpfile()as a result of discussion that was, in fact, related to its test failing on Termux shortly prior to the addition ofsbclto termux-packages, and that is OK and should not have any major effect on the tests we run here, because of ourtermux_tmpfile()implementation preventing it from returning null in most situations.