这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(scripts/revbump): handle more edgecases #24425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

fix(scripts/revbump): handle more edgecases #24425

merged 1 commit into from
Apr 23, 2025

Conversation

@truboxl
Copy link
Contributor

@truboxl truboxl commented Apr 20, 2025 •
edited
Loading

  • always check revision then fallback

Fix a bug where build.sh has TERMUX_PKG_REVISION but not
^TERMUX_PKG_REVISION causing revbump script to fail.

Bumping 1 packages

-1 -> 0 packages/libllvm/build.sh
  • detect multiline TERMUX_PKG_VERSION
  • detect TERMUX_PKG_VERSION+=()

@truboxl truboxl requested a review from Grimler91 as a code owner April 20, 2025 14:11
TomJo2000
TomJo2000 approved these changes Apr 20, 2025
View reviewed changes
Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that's the edgecase I hit in #24315 (comment)

@TomJo2000
Copy link
Member

TomJo2000 commented Apr 20, 2025 •
edited
Loading

Hey while you're at it, I found another bug with revbump.
Try ./scripts/bin/revbump manpages
It ends up doing this.

TERMUX_PKG_VERSION=(6.13
TERMUX_PKG_REVISION=1
                    2017)

It doesn't seem to handle multiline arrays for version numbers.

(Edit: thank you github that is exactly what I meant when I hit Ctrl + v)

@TomJo2000 TomJo2000 closed this Apr 20, 2025
@TomJo2000 TomJo2000 reopened this Apr 20, 2025
@truboxl truboxl force-pushed the revbump-fix branch 3 times, most recently from 1fca353 to fa3d786 Compare April 22, 2025 17:12
@truboxl truboxl changed the title fix(scripts/revbump): always check revision then fallback fix(scripts/revbump): handle more edgecases Apr 22, 2025
TomJo2000
TomJo2000 approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@truboxl
fix(scripts/revbump): handle more edgecases
cbac87e 
* always check revision then fallback

Fix a bug where `build.sh` has `TERMUX_PKG_REVISION` but not
`^TERMUX_PKG_REVISION` causing revbump script to fail.

```
Bumping 1 packages

-1 -> 0 packages/libllvm/build.sh
```

* detect multiline `TERMUX_PKG_VERSION`
* detect `TERMUX_PKG_VERSION+=()`
@truboxl truboxl merged commit 1e5d3d7 into termux:master Apr 23, 2025
@truboxl truboxl deleted the revbump-fix branch April 23, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomJo2000 TomJo2000 TomJo2000 approved these changes

@Grimler91 Grimler91 Awaiting requested review from Grimler91 Grimler91 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@truboxl @TomJo2000