-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
cmake -DBUILD_SHARED_LIBS=ON for all packets no static libs #24091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
s is better because builds failed without this. ffmpeg contains this check that doesn't accept static libs check_func_headers "$headers" "$funcs" $pkg_cflags $pkg_libs "$@" && besides static libs are absolutely insanity . I have on my to-do list to create share libs from netsurf for elinks libdom libcss should be broken out and build sharedas separate packets . -- UPDATE this is fixed and pending elinks including JavaScript is now down to one meg without debug symbols from over six meg---I really want to make more progress with elinks JavaScript . good old memories # possible bionic dlopen bug in Quick JS in quickjs@shared in my account a possible bug is explained in dlopen. unless there is something wrong with the build the linked JS interpreter fails to use dlopen from libquickjs.so . the exact same static program works and glibc shared with exact same build recipe. DL_DEBUG is also disabled in bionic but it would not say anything about dlopen only the initial linking . bionic is relatively small and it should be possible to test this on device it is only a few thousand files with a custom libc.so with logging for dlopen
It is an interesting idea, however, very unfortunately, that would break packages that require static libraries because of conflicts with shared libraries in
|
@@ -52,6 +52,7 @@ termux_step_configure_cmake() { | |||
-DCMAKE_USE_SYSTEM_LIBRARIES=True \ | |||
-DDOXYGEN_EXECUTABLE= \ | |||
-DBUILD_TESTING=OFF \ | |||
-DBUILD_SHARED_LIBS=ON \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However it should be noted that this would not actually turn off most static libraries (I think), it would only turn on shared libraries in many packages.
I think this could possibly unify 70 instances of -DBUILD_SHARED_LIBS=ON
in the repository, there are only two possible conflicting situations (I think), the special cases protobuf-static
(discussed above), and the other special case qbittorrent
(not sure of the reason for that one having -DBUILD_SHARED_LIBS=OFF
)
-DBUILD_SHARED_LIBS=OFF |
-DBUILD_SHARED_LIBS=OFF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As comments above, this should be added in TERMUX_PKG_EXTRA_CONFIGURE_ARGS
. I strongly oppose adding it to the default args.
I do not really remember, afaik somebody had "cannot link executable" problem. |
if that is true, then it could mean that might not be working correctly, because
as reported in I need to find a device that can reproduce that error, so that I can regression test the current versions of the package. |
s is better because builds failed without this. ffmpeg contains this
check that doesn't accept static libs
check_func_headers "$headers" "$funcs" $pkg_cflags$pkg_libs "$ @" &&
besides static libs are absolutely insanity . I have on my to-do list to
create share libs from netsurf for elinks libdom libcss should be broken
out and build sharedas separate packets . -- UPDATE this is fixed and pending elinks including JavaScript is now down to one meg without debug symbols from over six meg---I really want to make more
progress with elinks JavaScript . good old memories
possible bionic dlopen bug in Quick JS
in quickjs@shared in my account a possible bug is explained in dlopen.
unless there is something wrong with the build the linked JS
interpreter fails to use dlopen from libquickjs.so . the exact same
static program works and glibc shared with exact same build recipe.
DL_DEBUG is also disabled in bionic but it would not say anything about
dlopen only the initial linking . bionic is relatively small and it
should be possible to test this on device it is only a few thousand
files with a custom libc.so with logging for dlopen