-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Libxml2 rebuilds: Part 2 - Small packages #24062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dd48bc3
to
f40161d
Compare
It seems like it was a temporary server failure, since that file can be downloaded by my connection at the moment. |
All packages in this branch are now building successfully.
|
90d7c93
to
f3ed117
Compare
Seems to be the case, but since it's still failing on the CI I'll pull |
It seems like https://www.aleksey.com/xmlsec/download/xmlsec1-1.3.7.tar.gz has a problem with intermittent service interruptions, since it keeps having error 403 only sometimes. That means that there is a risk of it having error 403 during the post-merge build and failing to upload to the package host. I am not sure what to do in this situation. |
That's why I'd like to pull it out into a separate PR and merge it last. |
cdb535e
to
fd47441
Compare
This did not happen to me when I tested building it on april 1, |
|
I do not know why the error happened yet, it is very strange because, this commit built successfully on April 5 in CI, but when I use git to check out that commit and then build I can see that one difference is that the version of the python and in the changelog for https://github.com/pypa/wheel/releases/tag/0.46.0 "Removed the This is pretty confusing since this is something newly happening and maybe not very many people are using I will try to figure out if there is any way to resolve this error while using the new release of |
According to the discussion of others who suddenly also have the same error in this issue, it looks like we might need to bump our termux-packages/scripts/build/setup/termux_setup_python_pip.sh Lines 63 to 64 in 1217e5f
to a version that is at least 70 or newer to be updated to have compatibility with This would also be a good opportunity, in my opinion, to apply 763ef01 to |
Sounds good. |
- `wheel` version 0.46+ now requires `setuptools` version 70 or newer - discussed upstream here: pypa/wheel#660 - discovered in termux-packages here: termux#24062 (comment) - I have confirmed that this change works to fix the build of `python-lxml` **both** - **in `TERMUX_ON_DEVICE_BUILD=false` mode (broken for 1 week)**, - fixes `error: invalid command 'bdist_wheel'` - **and also in `TERMUX_ON_DEVICE_BUILD=true` mode (broken for 6 months)**. - fixes `ModuleNotFoundError: No module named 'setuptools'` - It seems appropriate to remove the `if [ "${TERMUX_PYTHON_VERSION#*.}" -lt "12" ]` block because there is no longer any `python3.11` so it does not seem like that code is reachable anymore.
- `wheel` version 0.46+ now requires `setuptools` version 70 or newer - discussed upstream here: pypa/wheel#660 - discovered in termux-packages here: termux#24062 (comment) - I have confirmed that this change works to fix the build of `python-lxml` **both** - **in `TERMUX_ON_DEVICE_BUILD=false` mode (broken for 1 week)**, - fixes `error: invalid command 'bdist_wheel'` - **and also in `TERMUX_ON_DEVICE_BUILD=true` mode (broken for 6 months)**. - fixes `ModuleNotFoundError: No module named 'setuptools'` - It seems appropriate to remove the `if [ "${TERMUX_PYTHON_VERSION#*.}" -lt "12" ]` block because there is no longer any `python3.11` so it does not seem like that code is reachable anymore. - `python-torchvision` needed ajustment of its custom `CFLAGS` to be `CXXFLAGS` instead, because the newer `setuptools` is now compiling it using `aarch64-linux-android-clang++` instead of `aarch64-linux-android-clang`. - `python-pip` and `python-pillow` both had locked `setuptools` in their `TERMUX_PKG_PYTHON_COMMON_DEPS` at versions slightly newer than the old global version, now that the global version is newer than either of those, they do not seem to need that anymore.
- `wheel` version 0.46+ now requires `setuptools` version 70 or newer - discussed upstream here: pypa/wheel#660 - discovered in termux-packages here: termux#24062 (comment) - I have confirmed that this change works to fix the build of `python-lxml` **both** - **in `TERMUX_ON_DEVICE_BUILD=false` mode (broken for 1 week)**, - fixes `error: invalid command 'bdist_wheel'` - **and also in `TERMUX_ON_DEVICE_BUILD=true` mode (broken for 6 months)**. - fixes `ModuleNotFoundError: No module named 'setuptools'` - It seems appropriate to remove the `if [ "${TERMUX_PYTHON_VERSION#*.}" -lt "12" ]` block because there is no longer any `python3.11` so it does not seem like that code is reachable anymore. - `python-torchvision` needed ajustment of its custom `CFLAGS` to be `CXXFLAGS` instead, because the newer `setuptools` is now compiling it using `aarch64-linux-android-clang++` instead of `aarch64-linux-android-clang`. - `python-pip` and `python-pillow` both had locked `setuptools` in their `TERMUX_PKG_PYTHON_COMMON_DEPS` at versions slightly newer than the old global version, now that the global version is newer than either of those, they do not seem to need that anymore.
fd47441
to
e12de9a
Compare
It will fail again I believe because this isn't merged yet, sorry about that, if you want I can merge it now so you can build this. |
If #24213 is ready for merge I'd like to get the libxml2 rebuilds wrapped up. |
What's weird now is that it stopped failing without the PR being merged, I think this might have happened because https://pypi.org/project/wheel/#history The reason given in the description there is "Causes CI failures where setuptools is pinned to an old version". Because of that, I guess the PR I opened doesn't necessarily need to be merged yet, so you can continue forward with this without worrying about that, and I can wait a bit longer before merging the PR. |
I mean, it's good that they retracted it since it has CI issues. |
- `wheel` version 0.46+ now requires `setuptools` version 70 or newer - discussed upstream here: pypa/wheel#660 - discovered in termux-packages here: termux#24062 (comment) - Lock `wheel` version at 0.46.1 so that if a future `wheel` update causes a similar problem in the future, it doesn't immediately propagate into termux-packages without us explicitly bumping it. Recommended by Tomjo2000 here: termux#24062 (comment) - I have confirmed that this change works to fix the build of `python-lxml` **both** - **in `TERMUX_ON_DEVICE_BUILD=false` mode (broken temporarily for 1 week)**, - fixes `error: invalid command 'bdist_wheel'` - **and also in `TERMUX_ON_DEVICE_BUILD=true` mode (broken for 6 months)**. - fixes `ModuleNotFoundError: No module named 'setuptools'` - It seems appropriate to remove the `if [ "${TERMUX_PYTHON_VERSION#*.}" -lt "12" ]` block because there is no longer any `python3.11` so it does not seem like that code is reachable anymore. - `python-torchvision` needed ajustment of its custom `CFLAGS` to be `CXXFLAGS` instead, because the newer `setuptools` is now compiling it using `aarch64-linux-android-clang++` instead of `aarch64-linux-android-clang`. - `python-pip` and `python-pillow` both had locked `setuptools` in their `TERMUX_PKG_PYTHON_COMMON_DEPS` at versions slightly newer than the old global version, now that the global version is newer than either of those, they do not seem to need that anymore.
… wheel 0.46.1 - `wheel` version 0.46+ now requires `setuptools` version 70 or newer - discussed upstream here: pypa/wheel#660 - discovered in termux-packages here: termux#24062 (comment) - Lock `wheel` version at 0.46.1 so that if a future `wheel` update causes a similar problem in the future, it doesn't immediately propagate into termux-packages without us explicitly bumping it. Recommended by Tomjo2000 here: termux#24062 (comment) - I have confirmed that this change works to fix the build of `python-lxml` **both** - **in `TERMUX_ON_DEVICE_BUILD=false` mode (broken temporarily for 1 week)**, - fixes `error: invalid command 'bdist_wheel'` - **and also in `TERMUX_ON_DEVICE_BUILD=true` mode (broken for 6 months)**. - fixes `ModuleNotFoundError: No module named 'setuptools'` - It seems appropriate to remove the `if [ "${TERMUX_PYTHON_VERSION#*.}" -lt "12" ]` block because there is no longer any `python3.11` so it does not seem like that code is reachable anymore. - `python-torchvision` needed ajustment of its custom `CFLAGS` to be `CXXFLAGS` instead, because the newer `setuptools` is now compiling it using `aarch64-linux-android-clang++` instead of `aarch64-linux-android-clang`. - `python-pip` and `python-pillow` both had locked `setuptools` in their `TERMUX_PKG_PYTHON_COMMON_DEPS` at versions slightly newer than the old global version, now that the global version is newer than either of those, they do not seem to need that anymore.
… wheel 0.46.1 (#24213) - `wheel` version 0.46+ now requires `setuptools` version 70 or newer - discussed upstream here: pypa/wheel#660 - discovered in termux-packages here: #24062 (comment) - Lock `wheel` version at 0.46.1 so that if a future `wheel` update causes a similar problem in the future, it doesn't immediately propagate into termux-packages without us explicitly bumping it. Recommended by Tomjo2000 here: #24062 (comment) - I have confirmed that this change works to fix the build of `python-lxml` **both** - **in `TERMUX_ON_DEVICE_BUILD=false` mode (broken temporarily for 1 week)**, - fixes `error: invalid command 'bdist_wheel'` - **and also in `TERMUX_ON_DEVICE_BUILD=true` mode (broken for 6 months)**. - fixes `ModuleNotFoundError: No module named 'setuptools'` - It seems appropriate to remove the `if [ "${TERMUX_PYTHON_VERSION#*.}" -lt "12" ]` block because there is no longer any `python3.11` so it does not seem like that code is reachable anymore. - `python-torchvision` needed ajustment of its custom `CFLAGS` to be `CXXFLAGS` instead, because the newer `setuptools` is now compiling it using `aarch64-linux-android-clang++` instead of `aarch64-linux-android-clang`. - `python-pip` and `python-pillow` both had locked `setuptools` in their `TERMUX_PKG_PYTHON_COMMON_DEPS` at versions slightly newer than the old global version, now that the global version is newer than either of those, they do not seem to need that anymore.
9257061
to
ace7673
Compare
Add polyfill implementation of `xmlShellPrintNode()` `libxml2` 2.14 has removed the function `xmlShellPrintNode()`, so this places a basic polyfill rewrite of it into the source code of `rdrview` 0.1.3 using code copied and pasted from the code that was removed from `libxml2`. tested with the command `rdrview -B firefox https://repology.org/maintainers/`, it appears to be working the same as it was with `libxml2` 2.13. Co-authored-by: Robert Kirkman <rkirkman@termux.dev>
fix build with `libxml2` 2.14 Fixes this error when building with libxml2 2.14 src/xml_pyx.c:203:36: error: expected ')' 203 | pyxExternalSubsetHandler(void *ctx ATTRIBUTE_UNUSED, const xmlChar *name, | ^ Probably has something to do with this commit in libxml2 GNOME/libxml2@208f27f Co-authored-by: Robert Kirkman <rkirkman@termux.dev>
ace7673
to
af9cf05
Compare
- Apparently missed during termux#24062
- Apparently missed during #24062
main/spatialite-tools- pulled out into Libxml2 rebuilds: Part 1 - Libraries #24060(should be merged together with
libspatialite
)main/xmlsec- pulled out into Libxml2 xmlsec #24211 due to flakey download source