这是indexloc提供的服务，不要输入任何密码
Skip to content

mesa: detect SVE/SVE2 support on ARM64 #24769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

mesa: detect SVE/SVE2 support on ARM64 #24769

merged 1 commit into from
May 23, 2025

Conversation

@licy183
Copy link
Member

@licy183 licy183 commented May 21, 2025 •
edited
Loading

Closes #24544
Closes #24360
Closes #22696

See also #24725

@licy183 licy183 requested a review from twaik May 21, 2025 05:16
@robertkirkman
Copy link
Member

robertkirkman commented May 21, 2025 •
edited
Loading

Unfortunately I do not have any devices that can reproduce the problems which might get fixed by this, but I have tested this on unaffected devices,
and I can confirm that the behavior of llvmpipe, lavapipe, turnip, and zink on devices which currently have no severe mesa problems, remains normal while using the artifacts of this PR, so this does not break anything on devices that do not have the llvmpipe crashing problem.

robertkirkman
robertkirkman reviewed May 21, 2025
View reviewed changes
@licy183 licy183 force-pushed the issue-24544 branch 3 times, most recently from b3a5704 to e98a745 Compare May 21, 2025 13:30
@licy183
Copy link
Member Author

licy183 commented May 23, 2025

I'll merge this at 20:00 (UTC+8) if there is no more review. Thanks！

truboxl
truboxl reviewed May 23, 2025
View reviewed changes
packages/mesa/0013-detect-sve-sve2-support.patch
+ MAttrs.push_back(token);
+ token = strtok_r(NULL, ",", &state);
+ }
+ free(dup);
Copy link
Contributor

@truboxl truboxl May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe set pointer to NULL after free pointer

Copy link
Member Author

@licy183 licy183 May 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I don't think it is necessary. dup is declared as a local variable and only can be used inside the if (env_extra_mattrs != NULL) { scope.

@licy183 licy183 merged commit 3d564ae into master May 23, 2025
11 checks passed
@licy183 licy183 deleted the issue-24544 branch May 23, 2025 12:59
@robertkirkman robertkirkman mentioned this pull request May 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@truboxl truboxl truboxl left review comments

@robertkirkman robertkirkman robertkirkman left review comments

@twaik twaik Awaiting requested review from twaik

@Grimler91 Grimler91 Awaiting requested review from Grimler91 Grimler91 is a code owner

@TomJo2000 TomJo2000 Awaiting requested review from TomJo2000 TomJo2000 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Can't launch dosbox-x and the-powder-toy [Bug]: godot package fail to run [Bug]: kitty crashing with current mesa drivers

3 participants

@licy183 @robertkirkman @truboxl