fix(termux_extract_dep_info): allow commands in *.subpackage.sh to fail #24690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I dunno about this one. |
Member
Author
|
But we used to use this behaviour before 622d796 |
Member
I'm not sure what you mean. |
Member
Author
|
There was no such line, but behaviour is same when you add |
Member
|
The build failure in the linked action may be related to this. https://github.com/termux/termux-packages/actions/runs/14975001019 |
Member
Author
|
Ok, so since old code allowed this and masked failures from this function I will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow commands like
cat ${TERMUX_PKG_TMPDIR}to fail inside subpackages buildscripts.Usually it does not directly affect target packages