这是indexloc提供的服务，不要输入任何密码
Skip to content

enhance(main/yazi): add .desktop entry #24676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

enhance(main/yazi): add .desktop entry #24676

merged 1 commit into from
May 30, 2025

Conversation

xronin01
Copy link
Contributor

No description provided.

TomJo2000
TomJo2000 approved these changes May 10, 2025
View reviewed changes
Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I assume this would mainly allow yazi to act as a mime handler for inode/directory items?

TomJo2000
TomJo2000 reviewed May 10, 2025
View reviewed changes
@TomJo2000 TomJo2000 requested a review from thunder-coding as a code owner May 12, 2025 21:30
@TomJo2000
Copy link
Member

TomJo2000 commented May 12, 2025 •
edited
Loading

Whoops, duplicated a commit there.
Anyway I added icon support to the docker image.

@xronin01 xronin01 force-pushed the master branch 3 times, most recently from 3f80810 to 1ae55bd Compare May 18, 2025 21:37
@xronin01 @TomJo2000
enhance(main/yazi): add .desktop entry and icons
dc3a425 
and clean up completions installation

Co-authored-by: TomIO <tom@termux.dev>
@TomJo2000
Copy link
Member

Hi sorry for letting this PR sit for 2 weeks.
I hadn't had the time to properly clean up the commit.
I've done so now.

We are now using a termux-proot-run based approach to generate the icons using imagemagick.
This means we do not need to ship the outdated imagemagick 6.9.12.98 package from Ubuntu 24.04 in the docker host.
Which simplifies things.
Using the proot wrapper does come with some performance overhead, this should be pretty negligible for the 7 icons we are resizing though.

@TomJo2000 TomJo2000 merged commit d9ff0cf into termux:master May 30, 2025
9 checks passed
@TomJo2000 TomJo2000 mentioned this pull request Jun 1, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomJo2000 TomJo2000 TomJo2000 approved these changes

@thunder-coding thunder-coding thunder-coding approved these changes

@Grimler91 Grimler91 Awaiting requested review from Grimler91 Grimler91 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xronin01 @TomJo2000 @thunder-coding