-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
scripts(toolchain): set ASFLAGS=-c #23456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fd82250
to
4ae2fdf
Compare
Hmm, what does this mean? |
We prefer not introduce merge commits in the git history as they unnecessarily muddy up the git history. |
Sorry hit the wrong button when posting. If you want additional information about the different PR merge options see this article in GitHub's documentation section. |
But my branch doesn't have any |
Oh, thanks, trying "Rebase branch".
|
I rebased locally (again) and |
Switched to "Update with rebase" |
I can't even demonstrate to |
That seems to just be a visual bug. |
Yeah we're still catching up on auto-updates since #22994 was just merged and the auto-update workflow reenabled. |
e9637a5
to
d3cc5e3
Compare
Ok but aven after local rebase |
I'm not seeing that. As you noted above, this PR is currently untested. |
The message is:
But I guess if its not visible to |
Odd. |
Correct! |
Fixes #23102
Untested.