addpkg(main/python-yt-dlp): 2025.02.19 - Migrate from TUR. #23789
Conversation
a1a4af6 to
7122226
Compare
| TERMUX_PKG_MAINTAINER="@termux" | ||
| TERMUX_PKG_VERSION=1.1.0 | ||
| TERMUX_PKG_REVISION=2 | ||
| TERMUX_PKG_SRCURL=https://github.com/google/brotli/archive/v$TERMUX_PKG_VERSION.tar.gz |
There was a problem hiding this comment.
This has the same TERMUX_PKG_SRCURL as main/brotli,
would it make sense to combine the build.sh and make this a subpackage of that?
termux-packages/packages/brotli/build.sh
Lines 5 to 6 in d5068a9
There was a problem hiding this comment.
I did not realize that.
It's definitely an option.
There was a problem hiding this comment.
I'd like to leave that for another time actually.
Mainly because I don't think subpackages support all required build variables.
https://github.com/termux/termux-packages/wiki/Creating-new-package#subpackage-build-script-variables
TERMUX_PKG_PYTHON_COMMON_DEPS in particular doesn't seems to have an equivalent for subpackages.
I'm not really happy with the current separation of subpackages as some separate class of package as I've stated previously and this seems to be another case to solidify that.
Leaving it as a separate package for the time being doesn't appear to have any adverse consequences.
It is independent from Brotli in all but source repository as is already.
There was a problem hiding this comment.
Yeah, I agree it's a bit confusing, but TERMUX_PKG_PYTHON_COMMON_DEPS is actually dependencies that only get installed while the package is building (there are no instances of packages or subpackages that install TERMUX_PKG_PYTHON_COMMON_DEPS during install-time rather than build-time).
Because of that, it means that you would actually put TERMUX_PKG_PYTHON_COMMON_DEPS in the build.sh of the main package, not the subpackage (because, since it's not possible to build a subpackage without also building the main package, the build dependencies of subpackages are defined in the build.sh of the main package).
There was a problem hiding this comment.
Having an interstitial main/python-brotli package at least makes the "succession" clearer.
Having a BREAKS/REPLACES for a TUR package is a bit iffy.
Although, I'm not even sure replacing a "standalone" package with a subpackage of the same name would require a breaks/replaces entry.
7122226 to
0131c53
Compare
This PR migrates
python-yt-dlpfrom the TUR.Additionally:
Sets a maintainer
Makes it provide
yt-dlpto aid package discoverabilityChanges
ffmpegfrom aTERMUX_PKG_SUGGESTS1 toTERMUX_PKG_RECOMMENDS2Clean up a few shellcheck warnings
Corresponding TUR PR: migrate(tur/python-yt-dlp): Promote to main repository termux-user-repository/tur#1593
Footnotes
Comma-separated list of packages that are related to or enhance the current one. ↩
Comma-separated list of non-absolute dependencies - packages usually used with the current one.
https://github.com/termux/termux-packages/wiki/Creating-new-package#package-build-script-variables ↩