bump(main/golang): 1.24.1 #23614
Merged
bump(main/golang): 1.24.1 #23614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c46b513 to
9e75a2f
Compare
|
Closes #23613. |
|
Seems like now everything is fine. I will merge this in 12 hours if nobody minds. |
|
I have a question about whether another change can be added here, Do you think it would be ok to do this? --- a/packages/golang/build.sh
+++ b/packages/golang/build.sh
@@ -51,8 +51,6 @@ termux_step_make_install() {
cp pkg/include/* $TERMUX_GODIR/pkg/include/
cp -Rf lib/* $TERMUX_GODIR/lib
cp -Rf misc/ $TERMUX_GODIR/
-}
-
-termux_step_post_massage() {
- find . -path '*/testdata*' -delete
+ # testdata directories are not needed on the installed system
+ find $TERMUX_GODIR/src -path '*/testdata*' -delete
}
|
|
Seems to be fine. I will add this a bit later. |
licy183
reviewed
Mar 6, 2025
robertkirkman
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a full rebuild of all packages for all archs and almost everything is rebuilt fine.
I did
./build-package.sh -I -f -a all ${PACKAGES}with this list.There are only two problematic packages:
mediamtx. Fail is not related to update. [Bug]: mediamtx can not be built for all architectures #23613step-cli. The error does not appear on1.24.0.For some reason I can not find the source it is referring to which is weird.