-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
addpkg(main/cdrkit): 1.1.11-5 #26979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d50c59 to
3961f1e
Compare
3961f1e to
51c06bc
Compare
adfc28b to
e1a02c3
Compare
|
To point out the obvious, the versioning and source availability for this package is more messy than for a typical package. |
|
It compiles successfully on my local machine, but when using GitHub CI, various problems mysteriously occur. |
|
The CI is most likely running into cross compilation issues since it is building the package on a x86_64 host. |
|
OK, I have found the cause; it's libandroid-glob and libandroid-utimes, they do not link automatically. |
e1a02c3 to
3f27139
Compare
|
Here ld.lld: error: undefined symbol: glob
>>> referenced by scsihack.c
>>> scsihack.c.o:(usalo_maxdma) in archive libusal/libusal.a
>>> referenced by scsihack.c
>>> scsihack.c.o:(usalo_maxdma) in archive libusal/libusal.a
ld.lld: error: undefined symbol: globfree
>>> referenced by scsihack.c
>>> scsihack.c.o:(usalo_maxdma) in archive libusal/libusal.a
clang: error: linker command failed with exit code 1 (use -v to see invocation) |
|
Yep that'd make sense. |
3f27139 to
499670e
Compare
|
Oh, I hate the shell script. |
|
I still think you might wanna consider packaging the |
499670e to
802b7ba
Compare
|
However, it seems that cdrtools has a particularly large number of set*uid calls, making it difficult to modify. |
|
cdrkit is still relatively less common |
|
I'm not certain either version of the utilities would even work without root privileges. |
|
set*uid is not supported on Android and will trigger EOSYSCALL |
Sure, my device doesn't have root access, but it can normally package an ISO. |
|
Okay that's good. |
I'm trying. I hope it can successful build. |
802b7ba to
f91adbc
Compare
|
I found that this report description was referring to Debian, so I made some modifications. |
f02e047 to
4c50821
Compare
|
@robertkirkman Do you think I should replace the 'report' description in the help information of all commands in cdrkit with my own email or with information directing users to submit issues to the termux-package repository? |
Or keep it as it is |
Here |
Please replace it with this kind of message: "Report problems to https://github.com/termux/termux-packages/issues" I don't think it is necessary to insert xingguangcuican666@foxmail.com, because issues should be publicly visible and not in private email. |
|
OKay |
4c50821 to
bcc83f6
Compare
|
I modified it |
|
Ok nice, I am finished with the PR I mentioned before, and now I'm working on part of this other issue, and then after I finish that I will review this PR more. |
|
Okay, I was just looking to see if there was anything else that could be optimized. |
|
Okay, at least for now I don't think there's much left to optimize. |
|
Hello? |
|
Hello I will help more soon but I had just been working on other PRs and issues that happened I'm sorry for delay |
|
Sorry to bother you. I will continue to wait for you. |
|
To give an update, one of the things that is taking me so long is, I want to verify that the do not worry I will eventually get it completely set up and I have all tools necessary to do so, but if you want to speed up the process then you can if you have access to such a device with that capability, you can also test and let me know what result you see. If you don't have access to such a device then don't worry, I do and I will eventually get completely set up and finish testing. |
|
Okay, I don't have suitable equipment for testing, but I will try to conduct the test in a virtual machine. Thank you so much. |
|
To add, I removed the remote SCSI functionality, as this feature is quite outdated and also causes some difficulties during compilation. |
|
Alright, I did my best; the virtual CD-RW on the Android x86 virtual machine doesn't seem to work properly. |
|
Thank you for trying, I can let you know that unfortunately, after setting up a functioning real Android-x86 device with a real physical CD-RW drive connected, I did test your version, and it is not able to control the real CD-RW drive. This occurs: however, I do have very good news. After 400 hours of work, I have separately created my own port of the My version is extremely different from the version that is in this PR. I still have more work to do to adjust the code and try to cross-compile it. I have not cross-compiled it yet and it might be very difficult to do that. If I am not able to cross-compile it successfully, I will put it in tur-on-device. When I finish adjusting my version eventually, I will upload it and then you can help me test it if you would like. I hope that my version will be able to also do the tasks you need to use it for. I focused specifically on implementing and testing the Here is a preview of what my version looks like: |
|
That's cool ! |
|
I'm really looking forward to its performance. |
|
I think I should create a PR and then release only the CDRKit source code related to ISO building. Because it seems that the cdrkit I ported only works with programs that operate on ISO files. |
Yes, I’d be happy to test it, but I only have a virtual machine. I can also help you see how to do it through cross-compiling. |
I am now able to provide a summarized response to this. As it has turned out,
I feel that maximizing the functionality and use-cases of the package is a high priority, so I am going to continue to progress on real |
|
I tried to port cdrtools, but I found that the build system is unusual and cannot correctly find the compilation environment on Termux. I am currently recreating a fork and trying to build it using GitHub's full CI. |
Yes, it is extremely difficult. but after a long time of working, I was able to successfully do it by applying dozens of patches and writing a long |
|
OK, I will wait for you. |
@robertkirkman I think that I did it.



cdrkit is a command-line toolkit for creating and burning CD/DVD image files.