-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
luarocks: build with lua54 #26914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luarocks: build with lua54 #26914
Conversation
0269f9e to
e0a418f
Compare
|
While this PR is simple it took me a whole night to understand how termux build system works. RTFM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are no other packages that depended on the termux-package-builder container having lua 5.1 in /usr (as opposed to the termux package lua 5.1 in $TERMUX_PREFIX), so lua 5.1 can be safely removed from setup-ubuntu.sh.
|
What's the benefit of building Luarocks against Lua5.4 anyway? LuaJIT does seem to be supported as a Lua 5.1 implementation, so would that be another option here or is there something I'm missing? |
|
Benefits? No, I didn't take that into consideration. Just bump to a newer version, and that's all. |
|
Yeah that's fine, just wanted to know if there was some other motivation for it. |
Signed-off-by: Ryan Keane <the.ra2.ifv@gmail.com>
Prerequisite for bumping lua version from 5.1 to 5.4 for luarocks. Signed-off-by: Ryan Keane <the.ra2.ifv@gmail.com>
e0a418f to
2820aeb
Compare
|
I've rebased this PR against the latest state of the |
TomJo2000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to merge, I'm just waiting for the I to finish on the latest rebase.
|
The CI seems to have hit a fluke failure state on the |
Unfortunately, the update seems to still not have reached the server: https://packages.termux.dev/apt/termux-main/pool/main/l/luarocks/ |
|
Reminder to self, do not merge stuff immediately before going to bed. |
I even didn't take a look at it, sry |
|
Network issue? |
|
https://github.com/termux/termux-packages/actions/runs/18581061027 |
|
Yeah, this fails because it was using docker image |
|
Okay so we just hit an edge case due to the image rebuild. |
In this situation, I think you should be able to solve this by opening another PR to revision-bump --- a/packages/luarocks/build.sh
+++ b/packages/luarocks/build.sh
@@ -3,7 +3,7 @@ TERMUX_PKG_DESCRIPTION="Deployment and management system for Lua modules"
TERMUX_PKG_LICENSE="MIT"
TERMUX_PKG_MAINTAINER="@termux"
TERMUX_PKG_VERSION="3.12.2"
-TERMUX_PKG_REVISION=2
+TERMUX_PKG_REVISION=3
TERMUX_PKG_SRCURL=https://luarocks.org/releases/luarocks-${TERMUX_PKG_VERSION}.tar.gz
TERMUX_PKG_SHA256=b0e0c85205841ddd7be485f53d6125766d18a81d226588d2366931e9a1484492
TERMUX_PKG_AUTO_UPDATE=trueyou can do it if you want or if you prefer, I can open it |
|
But why? Already bumped and no more changes, we just need a rebuild, using the new docker image |
|
Isn't triggering |
|
I think any one of "Members" can try re-running this job (Github allows you to do so) Or trigger a new job like this, this should be enough |
licy183 ended up doing the thing I said instead, in this: |
|
There has been a report that unfortunately, this PR caused the 3rd party software " I don't personally know how to fix that, but it appears that maybe, the change has caused some component or dependency of the 3rd party software to fail to detect the system
I don't personally know how to completely adapt this other distro's However, according to the issues page of the Arch Linux package, it seems like that approach might also not be completely without problems: https://gitlab.archlinux.org/archlinux/packaging/packages/luarocks/-/issues/4 @Ra2-IFV do you happen to know how to fix that? |
CI won't pass because current docker image doesn't have lua5.4
Also includes a small fix for linting on different branches, triggered by whatever