@sabamdarif If you cherry-pick this PR, does it work as an alternative solution?

• Prepare for GLib 2.86.0 typelib break linuxmint/cinnamon#13091

Another X11 GUI affected by an extremely similar problem is awesome. I am planning to fix it here:

• bump(x11/awesome): 2025.05.17 #26693

@sabamdarif If you cherry-pick this PR, does it work as an alternative solution?

* [Prepare for GLib 2.86.0 typelib break linuxmint/cinnamon#13091](https://github.com/linuxmint/cinnamon/pull/13091)

i will try

yes @robertkirkman it did work, i understand now that is the real issue thanks

very good, and should it be called "from" or "form"? I thought it should be "from"

o yes wait

very good, and should it be called "from" or "form"? I thought it should be "from"

from

In order to pass the CI it will need to have TERMUX_PKG_REVISION increased by 1 in the build.sh

That should have already been caught by the linter.

Why wasn't it...

In order to pass the CI it will need to have TERMUX_PKG_REVISION increased by 1 in the build.sh

oh yes i forgot about that

@TomJo2000 I don't fully understand how the linter works, but just looking at the part you highlighted, where does the {upstream} keyword "come from" there and how does the linter know what "upstream" is in that context?

~/code/termux-packages $ cat scripts/lint-packages.sh | grep upstream
        base_commit="$(git merge-base 'master@{upstream}' 'HEAD')"
~/code/termux-packages $

@TomJo2000 I don't fully understand how the linter works, but just looking at the part you highlighted, where does the {upstream} keyword "come from" there and how does the linter know what "upstream" is in that context?

That's some git-rev syntax¹.

@TomJo2000 ok that's great but it doesn't work on my computer (a Termux right now) when I try to test it. How is it meant to work in CI, do I have it set up wrong? Also, can this condition detect a problem if build.sh of the package is not edited (only .patch files edited) in the PR?

It's supposed to make a diff of the entire branch using git log --patch "${base_commit}.." -- "$package" to look for changes to the package.

$package is $1 of check_version_change...
Which is $package_script, the iterator variable over $@ of linter_main...
And linter_main gets called build.sh locations for all packages that are being linted.
So it should actually be looking at the package directory instead, good catch.

If you can see my screenshot, do you see as well how my Test.log is empty? it seems like it shouldn't be so that is why i focused on that part first, do you know why that could be? I am concerned a similar problem could be happening in CI.

If you can see my screenshot, do you see as well how my Test.log is empty? it seems like it shouldn't be so that is why i focused on that part first, do you know why that could be? I am concerned a similar problem could be happening in CI.

I'm guessing there's no branch.<name>.merge set up for the branch.
Can you check the branch entry for that branch in the .git/config of the repo?

~/code/termux-packages $ cat .git/config
[core]
        repositoryformatversion = 0
        filemode = true
        bare = false
        logallrefupdates = true
[remote "origin"]
        url = https://github.com/sabamdarif/termux-packages
        fetch = +refs/heads/*:refs/remotes/origin/*
[branch "fix-26742"]
        remote = origin
        merge = refs/heads/fix-26742
~/code/termux-packages $

Maybe the CI doesn't have the correct information configured in git at this point either, but I don't know for sure.

I'll throw a cat of the .git/config in there for debugging.

very good, and should it be called "from" or "form"? I thought it should be "from"

from

could you edit the commit to change that?

could you edit the commit to change that?

ok

To me it looks like when you try to change that, it doesn't change anything, maybe the way you are trying to change it isn't working?

i added it in both of this palaces, where did you mean ?

i use git commit --amend

Oh, when I asked you did you mean "form" or "from" I meant, about this "form":

did you mean this to be "form" or "from"?

oh my bad i understand it wrong , wait

Ok wonderful, now it's ready! I will merge it in 24 hours and I guess I will also merge my similar glib 2.86 compatibility PR for awesome in 24 hours.