Update NDK 23c patches #21499
Draft
Update NDK 23c patches #21499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I've just now had the time to get back to this.
|
Member
|
Ping @licy183 @fornwall @finagolfin @Grimler91 because you commited to |
finagolfin
reviewed
Oct 19, 2024
| #include <stdarg.h> | ||
| #include <stddef.h> | ||
|
|
||
| +#if !defined(__swift__) |
Member
There was a problem hiding this comment.
Not needed, the Swift changes are mainly for compiling Swift source on a Termux device with the ndk-sysroot package. If you don't use Swift or compile on-device with this 23c sysroot, you don't need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing different approaches to compile RNote, someone suggested that I attempt compiling it with an older NDK so I updated the patches needed for the NDK to work as the old patches don't apply anymore.
The patches needed were copied over from ndk 27's patches