audacity: fix no libSoundTouch.so #21872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Ugh yet again merge trigger happy, I will help thoroughly review |
Member
|
It is weird, probably I missed it when I synced dependency list with the one I found in CMakeLists.txt of the project... Also weird that both building on my machine and on CI did not report missing dependency, usually it reports undefined references... |
twaik
approved these changes
Oct 19, 2024
Contributor
|
There are still some build steps I disagree with in the original PR #21824. But I don't have much time to fix it here. So this will do for now. Thank you for bringing attention and fixing. |
Member
|
You did not post a review about build steps. What exactly is wrong? |
Contributor
|
You merge too early |
Member
|
You are right. But package worked fine for me and few more users who tested it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libsoundtouchneeds to be in the deps list of aduacity, otherwise it prompts this error on my device: