enhance(main/libuv): Check for TERMUX_EXEC__PROC_SELF_EXE #20767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes running e.g. neovim under `termux-exec` with updated `targetSdk`.
Member
Author
|
I've raised the question in the |
Grimler91
reviewed
Jul 2, 2024
Member
|
Before merging these type of PRs we should land termux/termux-exec-package#24 and #18872. Will look at it again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes running e.g. neovim under
termux-execwith updatedtargetSdk.Brief summary: When running with
targetSdkto 28 or higher, it's not allowed to execute downloaded files (files not part of the APK in general) directly.The
termux-execworkaround usingLD_PRELOADthat is currently used in the Google Play build instead executes e.g./system/bin/linker64 $PREFIX/bin/nviminstead of$PREFIX/bin/nvimdirectly. One consequence of that is that reading/proc/self/exeto get the path to the currently running executable does not work, so patches like these (that should be a no-op when not running under bumpedtargetSdkandtermux-exec) are necessary.