这是indexloc提供的服务,不要输入任何密码
Skip to content

ctags: add ctags-cross subpackage #22685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

stsp
Copy link
Contributor

@stsp stsp commented Dec 26, 2024

This patch adds ctags-cross subpackage that can be used for cross-builds. Had to increment version to force rebuild.

@twaik
Copy link
Member

twaik commented Dec 26, 2024

Had to increment version to force rebuild

That is the reason TERMUX_PKG_REVISION exists.

@Biswa96
Copy link
Member

Biswa96 commented Dec 26, 2024

stsp, Again! why are you keep creating pull requests for host packages which is not required for this repository?

This patch adds ctags-cross subpackage that can be used for cross-builds.

Added TERMUX_PKG_REVISION per @twaik suggestion, to force the rebuild.
@stsp
Copy link
Contributor Author

stsp commented Dec 26, 2024

stsp, Again! why are you keep creating pull requests for host packages which is not required for this repository?

Well, this time I put it into the subpackage,
as was suggested here:
#22569 (comment)
Why is this the problem?
The aforementioned smallerc-cross
subpackage is also not required for the
repository, yet I was suggested to create
it.

@stsp
Copy link
Contributor Author

stsp commented Dec 26, 2024

That is the reason TERMUX_PKG_REVISION exists.

Thanks for that info, done.
Especially good to know because I
had problems with colon in file name
when running things via termux-apt-repo
and upload-artifacts action.
With that change there is no more colon.

@Biswa96
Copy link
Member

Biswa96 commented Dec 26, 2024

Why is this the problem?
The aforementioned smallerc-cross
subpackage is also not required for the
repository, yet I was suggested to create
it.

Because smallerc-cross is probably required in that case. You have not provide any reason for this one and for this repository.

@stsp
Copy link
Contributor Author

stsp commented Dec 26, 2024

Because smallerc-cross is probably required in that case. You have not provide any reason for this one and for this
repository.

There are really no deps in this repo
currently for ctags-cross, as well as no
deps for smallerc-cross.
I just thought that if some package is
already being built, then adding a host
sub-package is not a big deal.
If this is a problem, I can close this PR.
But I really don't understand why, or
what's the difference with smallerc-cross.

@stsp
Copy link
Contributor Author

stsp commented Dec 26, 2024

And of course I need this for the packages
I build in my branch. Otherwise I wouldn't
be doing that.

@Biswa96
Copy link
Member

Biswa96 commented Dec 26, 2024

I think, the host sub-package is added only when it is required by more than one package. For example, qt6-base-cross, libwayland-cross etc.

@stsp
Copy link
Contributor Author

stsp commented Dec 26, 2024

Ah, sorry, smallerc-cross is self-required
(needed to build smallerc libs).
So yes, bad example, you are right.
So should I close this?

@stsp
Copy link
Contributor Author

stsp commented Dec 26, 2024

Ok.

@stsp stsp closed this Dec 26, 2024
@stsp stsp deleted the ctags-cross branch December 26, 2024 07:19
@Biswa96
Copy link
Member

Biswa96 commented Dec 26, 2024

By the way, your comments are formatted like a column. I'm not sure if it as GitHub issue.

@stsp
Copy link
Contributor Author

stsp commented Dec 26, 2024

Got too used to mobile where you don't have a space for long lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants