这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@truboxl
Copy link
Contributor

@truboxl truboxl commented Mar 12, 2024

Part of #10854
Close #19284
Close #19274
Close #18880

Not building other qt6 packages. Others can take the reign.

@truboxl truboxl marked this pull request as draft March 12, 2024 23:28
@Biswa96
Copy link
Member

Biswa96 commented Apr 23, 2024

Is there any issue which is blocking this pull request?

@truboxl truboxl force-pushed the qt6-qtbase branch 3 times, most recently from efc483f to 079e26d Compare May 3, 2024 15:07
@twaik
Copy link
Member

twaik commented May 13, 2024

It seems like there are much more packages requiring QT6 after update, including all KDE/Kirigami Frameworks packages, lxqt packages and mkvtoolnix. I marked all related auto-updater bot issues with qt6 label.

@twaik
Copy link
Member

twaik commented May 20, 2024

I am not complaining, but there are already 40 issues with qt6 tag, 37 of them are auto-updater issues. Is there anything I can help with?

For TERMUX_PKG_LICENSE_FILE multiline support
@truboxl truboxl changed the title DONOTMERGE: addpkg(x11): qt6-*, bump(x11/feathernotes,featherpad) DONOTMERGE: addpkg(x11): qt6-*, bump(x11/feathernotes,featherpad,mkvtoolnix) May 24, 2024
@truboxl truboxl force-pushed the qt6-qtbase branch 2 times, most recently from d6c2cfb to e41b9bb Compare May 24, 2024 06:27
@truboxl truboxl marked this pull request as ready for review May 24, 2024 22:25
Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested featherpad(-qt6) on my phone, seems to work as expected.

I'm gonna echo @Biswa96's question from earlier,
what's actually blocking merging for this PR?
This doesn't singlehandedly complete the Qt6 migration, but it's a solid first step towards that goal.

@truboxl truboxl changed the title DONOTMERGE: addpkg(x11): qt6-*, bump(x11/feathernotes,featherpad,mkvtoolnix) addpkg(x11): qt6-*, bump(x11/feathernotes,featherpad,mkvtoolnix) May 25, 2024
@truboxl
Copy link
Contributor Author

truboxl commented May 25, 2024

Thanks for the testing. I will merge it thus freeing up others to explore building other qt6 packages. Feel free to modify existing qt6 packages if they are blocking building other qt6 packages.

@truboxl truboxl merged commit 6a7cddd into termux:master May 25, 2024
@truboxl truboxl deleted the qt6-qtbase branch May 25, 2024 03:36
@Biswa96
Copy link
Member

Biswa96 commented May 25, 2024

I was building feathernotes and featherpad in package-builder container. qt6-qtbase-cross-tools and qt6-qtsvg-cross-tools were downloaded automatically but those are not mentioned in build depends. Could you explain the reason for that?

@truboxl
Copy link
Contributor Author

truboxl commented May 25, 2024

Likely because normal building of qt6-qtbase will result in building its subpackage qt6-qtbase-cross-tools too. Others correct me if I am wrong for this.

So in download and extract dependencies mode (build-package.sh -I) will pull the main packages as well as its subpackages.

Generally I don't explicitly fill TERMUX_PKG_BUILD_DEPENDS for cross-tools due to this quirk.

@TomJo2000 TomJo2000 mentioned this pull request May 25, 2024
5 tasks
@TomJo2000
Copy link
Member

Likely because normal building of qt6-qtbase will result in building its subpackage qt6-qtbase-cross-tools too.

And we need the *-cross-tools subpackage anyway for crosscompiling, right?
Makes perfect sense to automatically pull it in then when specifying qt6-qtbase, etc. as a dependency.

@Biswa96
Copy link
Member

Biswa96 commented May 31, 2024

Q. cat $PWD/user_facing_tool_links.txt | xargs -P${TERMUX_MAKE_PROCESSES} -L1 ln -sv is done in qt6-qtbase-cross-tools but not in qt6-qtbase, is that expected?

@truboxl
Copy link
Contributor Author

truboxl commented May 31, 2024

user_facing_tool_links.txt is empty for qt6-qtbase. Otherwise would have done the same action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto update failing for feathernotes Auto update failing for featherpad Auto update failing for mkvtoolnix

5 participants