mimetic: Add patch for c++17 (and ndk 26 compatibility) #18071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
56e40e2 to
34254dc
Compare
Need to link against libclang_rt.builtins-arm-android.a.
34254dc to
7b9615e
Compare
Member
|
Fixed arm build by linking against libclang_rt.builtins-arm-android.a (lets verify again that it build for all arches). |
Member
Author
Nice! The build is green on all arches, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the following PR: tat/mimetic#30.
Fixes c++17 compatiblity, and allows building with NDK 26 (#17863).