Fix arghandling, put test files in build directory #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I actually had the patch for this issue sitting in my old setup for sometime (like a year+), where I did the parsing myself instead of relying on getopt. But that partition now offered as a sacrifice to the Windows installation since I no longer use it, so it's lost forever :) |
The previous arghandling code expected args in a certain order. Switch to using getopt instead to solve the issue.
Even with --dry-run elf-cleaner modified the given binary. Fix the issue.
Currently elf-cleaner prints identical messages if multiple version sections are removed. Print which section is removed as well, so that it is easier to understand what is going on.
They are not suppose to be run, and only user needs to be able to read them.
2121daa to
b29e7eb
Compare
To make folder structure cleaner. Also change help message from .. termux-elf-cleaner .. to just .. elf-cleaner .., to make the tool even more general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to getopt_long instead of our own arghandling. One side-effect is that options like
-quiet -dry-run(with just one dash) will no longer work.Also fix bug for api 21 where file would be modified even with --dry-run.
Fixes #28