chore: switch build system to cmake #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grimler91
reviewed
Apr 2, 2024
Member
Grimler91
left a comment
There was a problem hiding this comment.
Considering recent events I agree that this is a good idea. I have some comments regarding tests part, but otherwise LGTM, thanks for working on this!
28a3f22 to
94056c9
Compare
There are multiple benefits of using CMake over Autotools like: - CMake is much more modern and requires much less lines of code as compared to doing the same thing in autotools - Autotools is years of bad decisions, generating a long 50k+ lines of bash script to generate the Makefiles definitely isn't a good idea and is really slow as well as makes debugging the build process very difficult - Existing projects using termux-elf-cleaner using CMake should benefit from this.
Member
Author
|
Merging this, will do a new 3.0.0 release after doing a bit of rewrite to make the overall code more readible. The command line parser is mess especially, will try to replace it with a more readible one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple benefits of using CMake over Autotools like:
compared to doing the same thing in autotools
bash script to generate the Makefiles definitely isn't a good idea and
is really slow as well as makes debugging the build process very
difficult
from this.