这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@yujincheng08
Copy link

Fix #16

@truboxl
Copy link

truboxl commented May 2, 2023

Suggest to change this to opt-in without checking e_type per my investigation #16 (comment)

@Grimler91 what do you think?

@yujincheng08
Copy link
Author

I think it is good. In fact, e_type is not accurate for determining PIE. The correct way is to check DT_FLAGS_1.

@Grimler91, what do you think?

@truboxl
Copy link

truboxl commented Jul 17, 2023

After reviewing again, I think this is unrelated to PIE.
It is more on to executable vs library and the recommendation to strip DT_PREINIT_ARRAY for executables.
Maybe can check using non-zero e_entry vs zero e_entry.

@syphyr
Copy link

syphyr commented Sep 2, 2023

I added the following changes to make it opt-in.
syphyr@393f32a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strip DT_PREINIT_ARRAY for PIE?

3 participants