-
Notifications
You must be signed in to change notification settings - Fork 72
termux-elf-cleaner: update the tool #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just a Makefile. Also set version to 1.10.0 (instead of 1.10) to follow semantic versioning.
It is used by other projects, so lets rename it to something that sounds less termux specific. Keep repo name, and projet name in configure.ac, as termux-elf-cleaner though. To change name of produced binary to termux-elf-cleaner we can use --program-prefix=termux- when configuring.
As recommended by the GPL.
Similar to what emacs uses. Will make it easier to add more options in future updates.
Print info about termux-elf-cleaner and copyright information if given.
In all printed messages, use PACKAGE_NAME instead.
If given, none of the info messages about removed entries will be printed (error messages are printed in both cases though).
We can then choose target api level during runtime and not just at compile time. --api-level NN can be used to choose for example api level 21, 24 or 30. If argument is omitted, then 21 is used.
To allow for checking if there are any unsupported entries in a program, but without modifying the program.
If any such entries are found. Ported from: https://github.com/Lzhiyong/termux-ndk/blob/master/patches/align_fix.py
It is not supported on api level 22.
Lets simply run termux-elf-cleaner on some programs/libraries and check so that output is what we expect. This will allow us to check so that updates do not break anything.
Add both un-cleaned ones, and cleaned ones for api level 24, for all arches.
Valgrind needs the tls alignment fix, so add original as well as fixed one that can be used for tests.
And remove author section, copyright info is kept individual file headers.
Using similar action as for termux-{app,api, ..}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And some additional updates