Update gradle plugin to version 4.1.3 to be in "sync" with termux-app project. #32
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ading another NDK version
|
Gradle plugin unlikely to cause download different NDK, but dependencies can do this. Termux has recently bumped its NDK version (https://github.com/termux/termux-app/blob/master/gradle.properties#L23) and released
Probably because NDK already was installed (that's a "side-by-side" installation which allows multiple versions). |
|
I noticed the issue I described after a clean Android Studio install.
I opened termux-app and received a complaint about the NDK installation
during the gradle sync, installed it.
Then when I opened the termux-float the IDE complained about another NDK
version missing, I bumped the version, did a sync and the build worked
without complaints. So I thought it was the cause, but maybe it's something
related with Android Studio.
Thanks
Em qui., 6 de mai. de 2021 18:10, Leonid Pliushch ***@***.***>
escreveu:
… Gradle plugin unlikely to cause download different NDK, but dependencies
can do this.
Termux has recently bumped its NDK version (
https://github.com/termux/termux-app/blob/master/gradle.properties#L23)
and released com.termux:terminal-view v0.112. Termux float uses older
variant of com.termux:terminal-view which is v0.106 only. That's why
different NDK is downloaded.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACKQOE7BU4LZ7RQZUGYUJ2DTMMAT5ANCNFSM44HVVNXA>
.
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project termux-app currently uses gradle-plugin version 4.1.3, and termux-float uses 4.0.0.
This version mismatch leads to slightly different build environments and the need to download different Android NDK versions (~1GB each) to build each project.
Bumping gradle plugin version from 4.0.0 to 4.1.3 avoids those different build environments (and the NDK download) and as far as I tested doesn't break the build.