Fix Termux crash on malformed config file #886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Great, we most certainly need more verification :) I also see that you've added an alternative config path (just mentioning it since it's worth mentioning) |
Contributor
Author
Nope, that wasn't me, this is already in master. I just splitted the try-catch clause into two parts: One for IOException handling and the other for parsing the JSON of extra-keys |
Member
Ah sorry, I blame my small phone screen. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having an malformed json input in the extra-keys property, the termux-app crashes later with an NullpointerException due to an uninitialized mExtraKeys variable.
This fix improves the parsing of the properties file. In case of an invalid "extra-keys" property, the variable will be initialized with length 0.