updated gradles, dependencies, plugins, and code #845
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TacoTheDank
commented
Sep 19, 2018
- java 1.8 compatibility
- build tools to 28
- gradle to 4.10.1
- updated some code to go with java 1.8
Signed-off-by: TacoTheDank <SkytkRSfan3895@gmail.com>
Signed-off-by: TacoTheDank <SkytkRSfan3895@gmail.com>
Signed-off-by: TacoTheDank <SkytkRSfan3895@gmail.com>
Signed-off-by: TacoTheDank <SkytkRSfan3895@gmail.com>
Signed-off-by: TacoTheDank <SkytkRSfan3895@gmail.com>
ghost
reviewed
Sep 19, 2018
| components: | ||
| - platform-tools | ||
| - tools | ||
| - tools |
Author
There was a problem hiding this comment.
from what i can remember, it ensures that it uses the most up-to-date sdk
There was a problem hiding this comment.
@TacoTheDank Actually, Travis ignores the duplicated lines.
Member
|
I'm closing this as there are quite some conflicts now. @TacoTheDank Some of the changes look good, but please try to split up unrelated changes into several PR:s if possible, that makes reviewing and integrating the changes a lot easier! |
Author
|
gotchu :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.