这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@lokesh-krishna
Copy link
Contributor

This adds support for adaptive icons on devices running Android 8.0 or higher while continuing to display the legacy icons on devices running older versions of Android.

@lokesh-krishna lokesh-krishna mentioned this pull request Jul 5, 2018
@flipflop97
Copy link

flipflop97 commented Jul 5, 2018

As your adaptive icon also changes the design of the icon (>_ instead of a block) I'd suggest also changing the other icons like the 'legacy' launcher one for the sake of consistency.

@trygveaa
Copy link
Contributor

trygveaa commented Jul 5, 2018

This icon is very similar to the ConnectBot icon though. It would probably be better to keep the block, rather than change it to >_.

@lokesh-krishna
Copy link
Contributor Author

@trygveaa, The icon is not just similar to ConnecBot. A prompt is used as the icon for terminal emulators across platforms. Each does it slightly differently though, be it colors or the characters used. I've actually used instead of the commonly used > and we also use different colors from the ConnectBot icon and different positioning as well.

The problem with using just a block is that without a border to offer a frame, the icon would just be a single white rectangle in a black background. I can't think of a way to offer a frame due to the various icon masks that might be applied to an adaptive icon. The alternative would be to throw the current icon on to a background but that is a compromise I'd rather not make.

@flipflop97 That's a fair point. I would like to know what @fornwall thinks about this. If we switch the legacy icon to this new one, Google recommends dropping the round icon unless the branding of the app relies on a circular shape (and I think it doesn't). So would it be okay to change the legacy icon to the square variant of the new one and drop the round icon?

@fornwall fornwall merged commit db13ea0 into termux:master Aug 1, 2018
@fornwall
Copy link
Member

fornwall commented Aug 1, 2018

This is now rolling out in version 0.65 of the app! Let's see how the feedback goes, and then we can proceed to update the old non-adaptive icon as followup work.

Thanks for the work @lokesh-krishna!

@lokesh-krishna
Copy link
Contributor Author

Does the notification icon have to be updated to reflect the new icon?

@trygveaa
Copy link
Contributor

#1478 updates the notification icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants