Update TerminalSession.java #434
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Endprocess string modified to check for `hushlogout` if exists then exit the terminal without echoing exit string
Grimler91
reviewed
Sep 25, 2017
| int exitCode = (Integer) msg.obj; | ||
| mShellExitStatus = exitCode; | ||
| mShellPid = -1; | ||
| mTerminalToProcessIOQueue.close(); mProcessToTerminalIOQueue.close(); |
Member
There was a problem hiding this comment.
I'm guessing this shouldn't be here twice?
Member
Contributor
Author
|
Hmm, that sounds like a problem, but I just made temp changes.. |
Contributor
Author
|
I'll just replace |
Echo message only if exit code is zero
|
@Grimler91 True, but the exit message wont protect you from everything anyway. Such as killall com.termux in your bashrc. A way to properly close termux panes programatically is sorely needed. Edit: woops. Just saw that you've already saw Issue 56 and referenced this from there. |
Member
|
Not relevant after #56. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endprocess string modified to check for
~/hushlogoutif exists then exit the terminal without echoing exitDescription