Changed: Updated FileReceiverActivityTest to include empty & null strings for invalidUrls to cover corner cases #4220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@agnostic-apollo, @fornwall, would you have some time to review my PR? Thanks. |
Member
|
Fix commit message. https://github.com/termux/termux-app#commit-messages-guidelines |
Contributor
Author
Can do. |
Contributor
Author
|
@agnostic-apollo, does my latest commit message conform to the guidelines now? |
Contributor
Author
I fixed my commit message. Thanks. |
…iverActivityTest`
bdd0abb to
18ca509
Compare
Member
|
Fixed and merged. Thanks. |
Member
|
Did you not bother running the tests to see if they actually passed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to FileReceiverActivityTest empty & null strings for invalidUrls to cover corner cases